Remove DROP from vulns creation #1281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This DROP was added in 01baac2, which changed the view to a UNION with explicit columns. It's likely that the DROP was needed because CREATE OR REPLACE does not support changing the columns. But that was 2017 and the columns have not changed since, so anyone upgrading from the last version will have the same columns. If someone need to change the columns they can add a migrator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This DROP was added in 01baac2, which changed the view to a UNION with
explicit columns. It's likely that the DROP was needed because CREATE OR
REPLACE does not support changing the columns.
But that was 2017 and the columns have not changed since, so anyone
upgrading from the last version will have the same columns.
If someone needs to change the columns they can add a migrator.
What:
Remove DROP from vulns creation.
Why:
We have reports of "ERROR: relation "vulns" does not exist" that are hard to reproduce, and this may help.
How:
Restart gvmd.
Checklist: