Fix SCP alert authentication and logging (20.08) #1264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The BatchMode=yes option for scp is removed to make sshpass work and the prompt expected by sshpass is adjusted for public key auth. Carriage return characters are removed from the log output as they can make journalctl interpret it as blob data.
bjoernricks
approved these changes
Aug 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The BatchMode=yes option for scp is removed to make sshpass work and the
prompt expected by sshpass is adjusted for public key auth.
Carriage return characters are removed from the log output as they
can make journalctl interpret it as blob data.
(This was originally fixed in gvmd-9.0 with #972 but not ported to the 20.08 branch)
Checklist: