Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the output for invalid / no --type parameter more verbose. #1255

Merged
merged 2 commits into from
Aug 14, 2020
Merged

Make the output for invalid / no --type parameter more verbose. #1255

merged 2 commits into from
Aug 14, 2020

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Aug 14, 2020

Fix coding style inconsistencies for all if[ ]; then cases.

To test run something like e.g. the following two for the output:

greenbone-feed-sync --type foo
greenbone-feed-sync foo

and for the help banner:

greenbone-feed-sync --help

Previous to this PR the output looked like:

No feed type given

and

Invalid feed type FOO

Now we're more verbose / having a more helpful message like:

No feed type given to --type parameter

and

Invalid feed type FOO given to --type parameter. Currently supported: CERT, SCAP or GVMD_DATA

Checklist:

Fix coding style inconsistencies for all if[ ]; then cases.
@cfi-gb cfi-gb requested a review from a team August 14, 2020 10:59
Copy link
Contributor

@bjoernricks bjoernricks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bjoernricks bjoernricks merged commit a2da469 into greenbone:gvmd-20.08 Aug 14, 2020
@cfi-gb cfi-gb deleted the feed_type_output branch August 14, 2020 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants