Remove initial offset from schedules #1121

mattmundell · 2020-06-08T19:43:04Z

Checklist:

This column was not being used. It was exposed to the client as a filter, but that is not useful.

timopollmeier

This looks okay overall, but the GMP change doc doesn't seem right to me.

src/schema_formats/XML/GMP.xml.in

Co-authored-by: Timo Pollmeier <[email protected]>

mattmundell added 3 commits June 8, 2020 21:38

Remove initial_offset from schedules

85c7563

This column was not being used. It was exposed to the client as a filter, but that is not useful.

Add filter term to CHANGE doc

75b1059

Update changelog

9affd5a

mattmundell marked this pull request as ready for review June 8, 2020 19:45

mattmundell requested a review from timopollmeier as a code owner June 8, 2020 19:45

mattmundell mentioned this pull request Jun 9, 2020

Make schedules work across time zone shift #1125

Merged

2 tasks

timopollmeier reviewed Jun 10, 2020

View reviewed changes

src/schema_formats/XML/GMP.xml.in Outdated Show resolved Hide resolved

mattmundell and others added 2 commits June 10, 2020 10:22

Improve GMP CHANGE wording

3c37fbd

Co-authored-by: Timo Pollmeier <[email protected]>

Merge branch 'master' into remove-initial-offset

d18773d

mattmundell requested a review from timopollmeier June 10, 2020 08:32

timopollmeier approved these changes Jun 10, 2020

View reviewed changes

mattmundell merged commit 99185fc into greenbone:master Jun 10, 2020

mattmundell deleted the remove-initial-offset branch June 10, 2020 10:33

y0urself mentioned this pull request Jul 7, 2020

mix in the mixins ..., refactoring unittests greenbone/python-gvm#254

Merged

3 tasks

Provide feedback