Improve refs and error handling in NVTs update #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the refs element is missing, it is simply ignored so the scanner no longer has to send an empty element. Also, if nvti_from_vt fails, update_nvts_from_vts will skip the VT instead of inserting a broken NVT into the table.
mattmundell
approved these changes
May 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the refs element is missing, it is simply ignored so the scanner no
longer has to send an empty element.
Also, if nvti_from_vt fails, update_nvts_from_vts will skip the VT
instead of inserting a broken NVT into the table.
Checklist: