Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Allow loading of locales like zh_TW #3895

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Fix: Allow loading of locales like zh_TW #3895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5f7fe2a
Fix: Allow loading of locales like zh_TW
bjoernricks Oct 9, 2023
31d7d4b
Add: Support zh languages for our i18n message extraction
bjoernricks Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .babelrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
[
"i18next-extract",
{
"locales": ["de"],
"locales": ["de", "zh_TW", "zh_CN"],
"pluralSeparator": null,
"contextSeparator": null,
"nsSeparator": null,
Expand Down
2 changes: 1 addition & 1 deletion scripts/cleanuptranslations.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
const fs = require('fs');

// all locales that are included in .babelrc
const languages = ['de'];
const languages = ['de', 'zh_TW', 'zh_CN'];

for (const lang of languages) {
const path = './public/locales/gsa-' + lang + '.json';
Expand Down
2 changes: 1 addition & 1 deletion src/gmp/locale/lang.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const I18N_OPTIONS = {
loadPath: '/locales/{{ns}}-{{lng}}.json', // e.g. /locales/gsa-en.json
},
supportedLngs: whitelist,
nonExplicitSupportedLngs: true,
nonExplicitSupportedLngs: false,
interpolation: {
skipOnVariables: false,
},
Expand Down