-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CRDOM203][5R] add DocType rule as ecorule #16
base: main
Are you sure you want to change the base?
[CRDOM203][5R] add DocType rule as ecorule #16
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
before merging this PR, waiting for #17, thus I modify this PR to Draft.
Then, add an explanation of adding this rule as "eco-design" type
tools/rules_config/_config.sh
Outdated
@@ -26,7 +26,7 @@ TAG_ECOCONCEPTION=test1 | |||
# TAG_ECOCONCEPTION= | |||
|
|||
# list of rule keys that will be updated with new tag | |||
RULES_KEYS=css:S4655,php:S2014,Web:ItemTagNotWithinContainerTagCheck | |||
RULES_KEYS=css:S4655,php:S2014,Web:ItemTagNotWithinContainerTagCheck,Web:DoctypePresenceCheck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove other rules because they are only for testing the system
Hi @Silicoman , please resolve conflicts and check again tests and your upgrade. |
# Conflicts: # tools/rules_config/_config.sh
i Have resolved with the new script. It's ok, logs below. I'm waiting infos from issue opened if it's a relevant.
|
# Conflicts: # tools/rules_config/SONAR_RULES_REUSED.md
Hi @Silicoman, |
Hi @Silicoman, Do you have this rule when you install SonarQube 10, locally ? |
As discuss here, green-code-initiative/ecoCode#103
Add new rule to label as eco-design