JDK11 retro-compatibility #90
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR downgrades the project from Java 17 to Java 11 for backward compatibility. The changes primarily replace pattern matching syntax introduced in Java 17 with traditional instanceof checks and casting.
- Replaces Java 17 pattern matching with traditional instanceof checks and explicit casting
- Updates Java version from 17 to 11 across configuration files
- Downgrades SonarQube version and license plugin version for Java 11 compatibility
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/main/java/org/greencodeinitiative/creedengo/python/utils/UtilsAST.java | Replaces pattern matching instanceof with traditional instanceof and casting |
| src/main/java/org/greencodeinitiative/creedengo/python/checks/DictionaryItemsUnused.java | Replaces pattern matching instanceof with traditional instanceof and casting |
| src/it/test-projects/creedengo-python-plugin-test-project/pom.xml | Updates Java version from 17 to 11 |
| pom.xml | Updates Java version, SonarQube version, and license plugin version for Java 11 compatibility |
| Dockerfile | Updates Maven builder and SonarQube version for Java 11 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
dedece35
added
🏗️ refactoring
|
|
converted to draft waiting for core-team decision if we keep JDK11 compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.