Facedancer v3.0.0 #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
antoinevg
force-pushed
the
antoinevg/facedancer-v3
branch
3 times, most recently
from
039531c
to
f5eec58
Compare
|
Would it be possible to port the |
|
The legacy keyboard examples based on I've got a bit much on my plate for the next few months to tackle porting the rest of the legacy keyboard examples myself, but if you are interested a good place to start would be to look at:
|
antoinevg
force-pushed
the
antoinevg/facedancer-v3
branch
from
131d96b
to
9c2fec4
Compare
antoinevg
force-pushed
the
antoinevg/facedancer-v3
branch
from
bb23d98
to
3893dc5
Compare
antoinevg
force-pushed
the
antoinevg/facedancer-v3
branch
from
61b5a00
to
732e1a5
Compare
antoinevg
force-pushed
the
antoinevg/facedancer-v3
branch
from
abaa902
to
2ae63e6
Compare
antoinevg
force-pushed
the
antoinevg/facedancer-v3
branch
3 times, most recently
from
57a0a52
to
1f2109c
Compare
The to_this_endpoint() decorator based on the _wrap_with_field_matcher() helper did not compare the requests index against the endpoints address but against the static value 0b10001111.
…multiple interfaces The to_this_interface() decorator based on the _wrap_with_field_matcher() did not check the "index" field of the request. Thus always the first interfaces request handler was run.
USBDevice.handle_generic_get_descriptor_request() is called from USBInterface and USBDevice. Both callers passed themself as "self", which is technicially not correct, as "self" always has to be of type USBDevice. Now the signature is changed, so that it shows all possible types correctly.
Issue originally reported in greatscottgadgets#51 Initial pull-request in greatscottgadgets#52 Closes greatscottgadgets#51 Closes greatscottgadgets#52
antoinevg
force-pushed
the
antoinevg/facedancer-v3
branch
from
1f2109c
to
adf8eb2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the core Facedancer
v2.ximplementation withfacedancer.futureand marks the beginning of facedancerv3.xdevelopment.If you're using scripts or training materials that depend on features or APIs deprecated in
v3.x, or simply seeking the old applets and examples, you can still access them in thev2.9.xbranch.