Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python requirements #63

Closed

Conversation

MatthewTingum
Copy link

I had been getting a device not found error when using my Facedander21. It turned out that I wasn't importing serial, but that specific error wasn't getting propagated back and instead turned up as "device not found".

Also fixed a comment noticed while tracking this down.

@MatthewTingum
Copy link
Author

I guess it bothers me that the import is inlined in the function too. Maybe we could discuss changing that?

@antoinevg antoinevg self-requested a review January 3, 2023 07:55
@antoinevg antoinevg mentioned this pull request Jan 4, 2024
@antoinevg
Copy link
Member

Thank you for the PR!

These are fixed in:

@antoinevg antoinevg closed this Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants