Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add USB Printer device #40

Closed
wants to merge 1 commit into from
Closed

Conversation

gdsports
Copy link

@gdsports gdsports commented Mar 4, 2020

USB Printer device

@ktemkin
Copy link
Contributor

ktemkin commented Mar 4, 2020

I'll review this in a bit -- but just FYI, the future branch is very close to being merged.

It might be a good idea to move this onto the new USBDevice base, as the current one is eventually going to be moved into facedancer.compat. I'll advise in a bit.

@ktemkin ktemkin self-requested a review March 5, 2020 00:00
@straithe straithe removed the request for review from ktemkin September 23, 2021 16:32
@straithe straithe added the enhancement potential new feature label Nov 1, 2021
@antoinevg antoinevg requested review from antoinevg and removed request for mossmann January 3, 2023 07:56
@antoinevg antoinevg mentioned this pull request Jan 4, 2024
@antoinevg
Copy link
Member

Hi there, thank you for the PR and my apologies for the long wait!

I'm currently working on releasing the future branch of Facedancer and I'm wondering if you're still interested in working on this?

@antoinevg
Copy link
Member

I'm going to close this for now, please feel free to re-open this if you want to pick it up again.

@antoinevg antoinevg closed this May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement potential new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants