[BUGFIX] Remove illegible duplicate local Data Docs link from Slack renderer #10129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanFarmer
commented
Jul 19, 2024
| @@ -95,6 +95,7 @@ def test_SlackRenderer_validation_results_with_datadocs( | |||
| validation_result=validation_result_suite, | |||
| checkpoint_name="checkpoint_name_testing", | |||
| name="testing", | |||
| validation_result_urls=["file:///localsite/index.html"], | |||
There was a problem hiding this comment.
This array was not empty in practice. This change protects against regressions.
|
Does this fix this issue? |
@Kilo59 Yes, that is what this is meant to address. |
Kilo59
approved these changes
Jul 19, 2024
Co-authored-by: Gabriel <[email protected]>
This was
linked to
issues
Jul 19, 2024
NathanFarmer
deleted the
b/ph-1327/slack-renderer-multiple-validation-result
branch
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
invoke lint(usesruff format+ruff check)For more information about contributing, see Contribute.
After you submit your PR, keep the page open and monitor the statuses of the various checks made by our continuous integration process at the bottom of the page. Please fix any issues that come up and reach out on Slack if you need help. Thanks for contributing!