Skip to content

Commit

Permalink
[BUGFIX] test_diagnostic_checklist import error (#10934)
Browse files Browse the repository at this point in the history
  • Loading branch information
NathanFarmer authored Feb 13, 2025
1 parent c6c3cc4 commit b5a50e7
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions great_expectations/self_check/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,6 @@
import_library_module,
)
from great_expectations.validator.validator import Validator
from tests.test_utils import get_default_mssql_url

SQLAlchemyError = sqlalchemy.SQLAlchemyError

Expand Down Expand Up @@ -820,7 +819,11 @@ def build_sa_validator_with_data( # noqa: C901, PLR0912, PLR0913, PLR0915 # FIX
connection_string = f"mysql+pymysql://root@{db_hostname}/test_ci"
engine = sa.create_engine(connection_string)
elif sa_engine_name == "mssql":
connection_string = get_default_mssql_url()
connection_string = (
"mssql+pyodbc://sa:ReallyStrongPwd1234%^&*@127.0.0.1:1433/test_ci"
"?driver=ODBC Driver 18 for SQL Server&charset=utf8"
"&autocommit=true&TrustServerCertificate=yes"
)
engine = sa.create_engine(connection_string)
elif sa_engine_name == "bigquery":
connection_string = _get_bigquery_connection_string()
Expand Down Expand Up @@ -1398,7 +1401,11 @@ def build_test_backends_list( # noqa: C901, PLR0912, PLR0913, PLR0915 # FIXME C
test_backends += ["mysql"]

if include_mssql:
connection_string = get_default_mssql_url()
connection_string = (
"mssql+pyodbc://sa:ReallyStrongPwd1234%^&*@127.0.0.1:1433/test_ci"
"?driver=ODBC Driver 18 for SQL Server&charset=utf8"
"&autocommit=true&TrustServerCertificate=yes"
)
try:
engine = sa.create_engine(connection_string)
conn = engine.connect()
Expand Down

0 comments on commit b5a50e7

Please sign in to comment.