Skip to content
This repository was archived by the owner on Dec 30, 2020. It is now read-only.

Windows Version#2

Merged
gre merged 3 commits intogre:masterfrom
ryanlntn:windows
Mar 11, 2017
Merged

Windows Version#2
gre merged 3 commits intogre:masterfrom
ryanlntn:windows

Conversation

@ryanlntn
Copy link
Copy Markdown
Contributor

Add windows version per gre/react-native-view-shot#45

@gre
Copy link
Copy Markdown
Owner

gre commented Mar 10, 2017

that's awesome! did you succeed to make some third party lib work? (I'm just asking for react-native-maps and react-native-video as for gl-react-native it's not available – if it crashes, I'm ok with branching some code)

would you mind checking on a device and tell me which of the following works:

  • WebView
  • react-native-video
  • react-native-maps

?

in the readme of react-native-view-shot, I've recently started this compatibility table

screen shot 2017-03-10 at 10 35 56

which is a quick way to know if it's possible to check some interoperability (e.g. on Android, it's a pain to snapshot anything a bit more complex, like gl view, video,..)

Best would be for me to run it, but I don't have a windows phone :'(

@ryanlntn
Copy link
Copy Markdown
Contributor Author

@gre No problem. 😄

I updated the support table in gre/react-native-view-shot#45
gl-react and react-native-maps crash on attempting to import since they don't have any windows support yet. react-native-video should have windows support but I wasn't able to get it working. I suspect that if I could get the video working it would work but I marked it as no for now. WebViews and other native views appear to be working fine.

rn-view-shot

@gre gre self-assigned this Mar 11, 2017
@gre gre merged commit 92f967b into gre:master Mar 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants