Added summary from hits collection #5
Conversation
|
@robbanp if you would sign the CLA we could merge that PR - if not it will be closed in a week. thanks |
|
@jalogisch CLA? :) |
|
@jalogisch Done! |
|
✅ Confirmed that the CLA has been signed on Jul 17, 2017 3:14:49 PM (probably in the Graylog2 organization instead of graylog-labs). |
| @@ -7,7 +7,7 @@ | |||
|
|
|||
| <groupId>org.graylog.plugins</groupId> | |||
| <artifactId>graylog-plugin-pagerduty</artifactId> | |||
| <version>1.3.1-SNAPSHOT</version> | |||
| <version>1.3.2-SNAPSHOT</version> | |||
There was a problem hiding this comment.
Please revert this unrelated change.
| @@ -50,7 +50,7 @@ public URI getURL() { | |||
|
|
|||
| @Override | |||
| public Version getVersion() { | |||
| return new Version(1, 3, 1, "SNAPSHOT"); | |||
| return new Version(1, 3, 2, "SNAPSHOT"); | |||
There was a problem hiding this comment.
Please revert this unrelated change.
| @@ -154,13 +154,15 @@ private PagerDutyEvent buildPagerDutyEvent(final Stream stream, final AlertCondi | |||
| final String description = "[ " + stream.getTitle() + " ] " + checkResult.getResultDescription() + " - " | |||
| + buildStreamLink(clientUrl, stream); | |||
|
|
|||
| final List<Message> backlog_items = getAlarmBacklog(checkResult); | |||
There was a problem hiding this comment.
Please use camelCase for variable names, e. g. backlogItems and backlogSummary.
| for (Message message : messages) { | ||
| final String msg = message.getMessage(); | ||
| if (msg.length() > 225) { | ||
| sb.append("Message: {").append(msg.substring(0, 255)).append("... } "); |
There was a problem hiding this comment.
Shouldn't this use the same number in the condition (225) and inside the block (255)?
|
@robbanp will you work on the suggestions? |
|
@jalogisch I can |
|
@robbanp Any news here? |
|
Robert Pohl seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
So, we can get a brief summary of the alert messages in the incident alarm
Closes #4