gpld-conditional-limits.php: Added a new snippet to enable conditional date limits.
#884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barthc
force-pushed
the
barth/add/70534-conditional-limit-dates
branch
3 times, most recently
from
cdfac92
to
6a11d70
Compare
spivurno
requested changes
Sep 13, 2024
There was a problem hiding this comment.
Dude!! Very excited about this. Some feedback:
https://www.loom.com/share/279be099b3024bc6a9b1b04701300eb3
- Set settings by default so they don’t have to manually mapped if they’re unaffected.
- Also, some properties are not supported (e.g.
inlineDatepicker).
- Also, some properties are not supported (e.g.
- Need to output script in the footer. See: https://github.com/gravitywiz/snippet-library/blob/master/gw-snippet-template.php#L83C2-L91C3
- Need to enqueue
conditional_logic.jsif this script is used.
Update: Oh, and I forgot to mention, we should probably clear out the value if it is not a valid date based on the new configuration when a new conditional configuration is applied.
barthc
force-pushed
the
barth/add/70534-conditional-limit-dates
branch
2 times, most recently
from
2c31932
to
d11cfa5
Compare
|
@barthc Getting close! A few lingering issues:
|
barthc
force-pushed
the
barth/add/70534-conditional-limit-dates
branch
from
d11cfa5
to
d344efc
Compare
…nal date limits.
barthc
force-pushed
the
barth/add/70534-conditional-limit-dates
branch
from
d344efc
to
d4c93d7
Compare
spivurno
approved these changes
Sep 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
⛑️ Ticket(s): https://secure.helpscout.net/conversation/2690682399/70534
Summary
Added a new snippet to enable conditional date limits.