Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change zoom level and text size for place=hamlet #3626

Merged
merged 3 commits into from
Jan 16, 2019

Conversation

jeisenbe
Copy link
Collaborator

@jeisenbe jeisenbe commented Jan 8, 2019

Fixes #1984

Changes proposed in this pull request:

  • Start rendering hamlets at z14 (instead of z15) through z17
  • Use a slightly larger text label for hamlets, intermediate between place=quarter and place=neighborhood / locality / farm
  • Move place=hamlet to same layer as place=quarter

Explanation:

  • In areas where hamlets are common, the map may not display any place names, or too few, at z14
  • Mappers sometimes misuse place=village for very small settlements so that they will render sooner. This change will reduce this incentive.
  • Hamlets are larger and more important than farms, isolated_dwellings, and "localities", since they are found in rural areas but have more than one or two families, so they should be rendered sooner and with a subtly different text.

Test renderings:

Wales
high latitude
z14 Trefin - current
z14-trefin-master
After
z14-trefin-hamlet

z14 Dobshill - current
z14-dobshill-master
After
z14-dobshill-hamlet

Sixaloa, Costa Rica
low latitude
z14 current rendering:
z14-sixaola-master
After
z14-sixaola-hamlets

Syokosimo, Papua Indonesia
low latitude
z14 current
z14-syokosimo-master
z14 after
z14-syokosimo-hamlet2

Soba, Papua Indonesia
z18 current
z18-soba-master
z18 after
z18-soba-hamlet

  • There is no need to show these labels on z18 and z19

Also see additional images in #1984 (comment)

@jeisenbe jeisenbe changed the title Change initial zoom level and text size for place=hamlet Change zoom level and text size for place=hamlet Jan 8, 2019
@matthijsmelissen
Copy link
Collaborator

matthijsmelissen commented Jan 8, 2019

Start rendering hamlets at z14 (instead of z15) through z17

This would partially revert #1247.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 8, 2019 via email

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 8, 2019

In general I like this idea.

@jeisenbe
Copy link
Collaborator Author

jeisenbe commented Jan 8, 2019

In favor of rendering hamlets of z14, also consider the other features that start rendering at this zoom level:

  • highway=service (most types, but driveways are at z16)
  • highway=path, footway
  • highway=pedestrian
  • highway=construction (generic construction, plus residential, unclassified, etc)
  • building areas
  • swimming pool areas
  • parking areas
  • man_made=cutline, =embankment
  • tourism=wilderness_hut, =alpine_hut
  • waterway=waterfall, taller than 10m
  • man_made=tower, =mast taller than 160m, =telescope with diameter > 60m
  • railway=level_crossing
  • natural=cape and =bay text labels

It's odd not to show the name label for a hamlet at z14, when the buildings, service and pedestrian roads, footways and parking areas area already shown.

Also, landuse labels (such as landuse=residential, landuse=farmland) already render even sooner than z14, as long as the areas is larger than about 30 by 100 pixels. Many hamlets are smaller than this at z14, but some are large enough that the label will show if they are tagged as landuse=residential with name=*, for example "Simpson cross" in Wales:

z14 after
z14-keeston-hamlet

z14 current rendering
z14-keeston-master

Localities, farms and isolated dwellings can remain at z15 (and perhaps localities should be even later?), because they are often as small as one or two buildings, usually 1/4 or 1/16 the area of a hamlet (so they can be 1 to 2 zoom levels later).

@jeisenbe
Copy link
Collaborator Author

Does anyone want to see more test renderings? Any questions or concerns about rendering hamlets from z14, or about no longer rendering the name label at z18 and z19?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Jan 16, 2019

It looks OK for me - the difference in the font size is clear and I think it makes sense to not show the label of the area at every level.

https://www.openstreetmap.org/#map=14/52.0038/21.0371

z14, Before

screenshot_2019-01-16 openstreetmap carto kosmtik

z14, After

screenshot_2019-01-16 openstreetmap carto kosmtik 1

It's also better that they are bigger on z15, so they're different from roads:

z15, Before

screenshot_2019-01-16 openstreetmap carto kosmtik 2

z15, After

screenshot_2019-01-16 openstreetmap carto kosmtik 3

@kocio-pl kocio-pl merged commit 1bed8cc into gravitystorm:master Jan 16, 2019
@jeisenbe jeisenbe deleted the hamlet branch January 17, 2019 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants