Change scrub color and pattern #3529
Conversation
Added new scrub pattern file http://www.imagico.de/map/jsdotpattern.php#x,512,jdp60679;g,24,64,64;rx,25,2,64,64;rx,25,2,64,64;rx,25,2,64,64;rx,25,2,64,64;rd,1,1,0,scrub2,1,5,5,0,jdp97432,b0be93,c8d7ab; Add pixel-aligned scrub pattern and lch code
|
Here are some lower zoom levels to compare with farmland and heath: Goodwick, Wales z13 Before z14 Before Graig Isaf, Wales |
|
Some areas with detailed landcover mapping in the Azores Islands, including scrub, forest, heath, grass, marsh, intermittent lake and intermittent streams. Caldeira, Azores Islands Estrada da Caldeira, Azores Sicosta, Azores |
|
@jeisenbe The original proposition was c8d6ab so why it has changed to c8d7ab here? PS. Please do not put certain colour values in PRs names as we often change them during PR discussion and it might be confusing. |
|
Yes, the names of tickets should be short and succint in general, the rest should be inside. |
|
It was always #c8d7ab in the test images that I was showing on issue #2098, but perhaps I mistyped the code in the comments? #c8d7ab is #d1e0b4 is 3% darker, by Lch. There is no perceptible difference between c8d6ab and c8d7ab.
Sorry about the title, I'll shorten it. |
jeisenbe
changed the title
|
I will certainly need to adjust to this new brownish-green rendering of scrub, but it is still green and it really solves the water rendering problem. We have some more green areas changes ahead and let's see how they play together. Thanks for the coding work and analysis for all the people involved in this! |
|
@jeisenbe, I happened to notice that the new scrub pattern disappears one zoom level lower then forest. Could it perhaps be tweaked so they both disappear at the same level? (I can't remember if it did the same thing before the change or not, but I thought it might be due to the new density or something). |
|
This is the same as before; the forest/wood pattern already appeared sooner
…On Mon, Dec 24, 2018 at 9:49 AM Adamant36 ***@***.***> wrote:
@jeisenbe <https://github.com/jeisenbe>, I happened to notice that the
new scrub pattern disappears one zoom level lower then forest. Could it
perhaps be tweaked so they both disappear at the same level? (I can't
remember if it did the same thing before the change or not, but I thought
it might be due to the new density or something).
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3529 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshCEXhH_e_MmMJ0ISThvGldZueMJIks5u8CSngaJpZM4YyJ81>
.
|
|
Bummer. Maybe I'll do an issue to see if there's any will to change it then. |
|
We just decided to render the allotments pattern at z13, so it could make
sense to start showing the scrub patterns, orchards, vineyard and wetlands
at z13.
But it may not work with patterns that are much wider-spaced, like scrub.
The allotments pattern is only 4x4 pixels, while scrub needs about 20x20
pixels to repeat IIRC
…On Mon, Dec 24, 2018 at 10:07 AM Adamant36 ***@***.***> wrote:
Bummer. Maybe I'll do an issue to see if there's any will to change it
then.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3529 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshJFDGZX7-ZndcK5V1B3V_QYONiIgks5u8CjQgaJpZM4YyJ81>
.
|
|
I say if it works we do it. I don't see why it wouldn't on larger areas. Although a 16x16 pixel difference is rather large. |
|
I was going to notice this problem. It can be annoying with large scrub areas like here: https://www.openstreetmap.org//#map=13/34.2229/-117.8636 please fix it. |
|
Wow, that's a huge scrub area. There's no reason the pattern shouldn't still display at z13 with a place like that. |
|
Someone should start a new issue so we don’t forget about it over the
holiday.
Merry Christmas Eve from the West Pacific, everyone.
…On Mon, Dec 24, 2018 at 4:58 PM Adamant36 ***@***.***> wrote:
Wow, that's a huge scrub area. There's no reason the pattern shouldn't
still display at z13 with a place like that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3529 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshCzQHk9dDma6mLZtHxvOm8HlfVAZks5u8IkOgaJpZM4YyJ81>
.
|
Fixes #2098 - "[Intermittent] Stream is Barely Visible on Scrub"
Related to #2069, However does not yet change the color of golf courses, which use the same color as current scrub but without a pattern. This should be addressed soon, perhaps by changing golf to use the leisure color.
Changes proposed in this pull request:
The current scrub color is: #b5e3b5 = Lch(86,29,143), hsla(120,45%,80%,1)
_The current scrub pattern uses: #8ece8f = Lch(77,41,143)
2. Change scrub pattern to use: #b0be93 = Lch(75,24,122)
Test rendering with links to the example places:
http://www.openstreetmap.org/#map=15/20.7490/-156.8960
Hawaii z15
Before
After
Hawaii z16 http://www.openstreetmap.org/#map=16/20.7490/-156.8960
Before
After
Test area z15
=
Before
After