Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change color for apron in aerodromes #3444

Merged
merged 1 commit into from
Oct 15, 2018
Merged

Change color for apron in aerodromes #3444

merged 1 commit into from
Oct 15, 2018

Conversation

Adamant36
Copy link
Contributor

This PR changes the color for aprons in aerodromes. As they are currently to prominent. Closes #3385
apron before 1
apron after 1
apron before 2
apron after 2
after before 3
apron after 3

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 9, 2018 via email

@Adamant36
Copy link
Contributor Author

@jeisenbe, your welcome :)

@Tomasz-W Tomasz-W mentioned this pull request Oct 9, 2018
26 tasks
@Tomasz-W
Copy link

Tomasz-W commented Oct 11, 2018

@jeisenbe @kocio-pl Comparing it to landuse=residential in the the last test rendering, I'm worried that this colour may be too light and taken as some cultural-like area rendering (like eg. landuse=residential or landuse=industrial etc.), but this is a landcover feature and we usually render them darker.
@Adamant36 Can you try with darker #ceced9?

@kocio-pl
Copy link
Collaborator

kocio-pl commented Oct 11, 2018

I have no such worries - this is one of the rare objects which has very clearly defined context, nobody will expect residential area on the airport, especially directly connected to the aeroways... However testing alternatives is always possible and I'm glad that you care.

@kocio-pl
Copy link
Collaborator

Comparison:

original

923oeels

#ceced9

etydflji

@Adamant36
Copy link
Contributor Author

Adamant36 commented Oct 12, 2018

I was thinking there might be a chance the other color is to close to residential, but I agree with @kocio-pl about the context. There's almost no way to confuse them since its in an airport. Plus, I think #ceced9 is slightly to dark and a little on the purple side anyway.

@kocio-pl kocio-pl merged commit cce879c into gravitystorm:master Oct 15, 2018
@kocio-pl
Copy link
Collaborator

Thanks for another PR solving the issue!

I also think lighter color is better and it didn't look like any discussion is still going on, so I merged it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants