Add special icon for shop=trade, shop=wholesale

[Adamant36]

Adds icon for shop=trade, shop=wholesale closes #3291

Shop=trade (uses same updated icon as shop=wholesale)
https://www.openstreetmap.org/#map=19/37.77322/-122.41143 (way)

https://www.openstreetmap.org/#map=19/37.76920/-122.40372 (node)

Shop=wholesale
https://www.openstreetmap.org/#map=19/40.66082/-73.72151 (way)

https://www.openstreetmap.org/#map=19/40.73295/-73.86265 (node)

[Tomasz-W]

@Adamant36 Can you try with asymmetrical, but pixel-aligned version?:

Gist link: https://gist.github.com/Tomasz-W/79e6deb43381777ed666e8911c240743

[meased]

Definitely needs pixel alignment.

[lakedistrictOSM]

There's also the pixel aligned icon that I designed, linked in the original issue. However Tomasz's asymmetric version is an improvement on his original.

I'd also like to see this icon used for cash and carry shops (shop=wholesale).

[Adamant36]

Asymmetrical version 1

Asymmetrical version 2

I think I prefer the first version

I'm more then willing to add it as the icon for shop=wholesale also. It seems like the tag has enough uses. As long as others agree.

[kocio-pl]

Could you also test symmetric pixel aligned version?

shop=wholesale makes sense for me too - not too many uses, but it's fast growing:

[Adamant36]

@kocio-pl, I thought thats what I tested in the message above yours? Is that not what @Tomasz-W provided a few messages up or are talking about @lakedistrictOSM's icon in the original issue. I know nothing about how icons and pixel alignment work.

I'll add shop=wholesale then once the icon gets worked out.

[kocio-pl]

Well, I thought @lakedistrictOSM wrote it because his icon has not been tested. Which one did you use in the original rendering test?

[Adamant36]

@kocio-pl the original rendering test was done with @Tomasz-W's original version. Here's a test of @lakedistrictOSM's versions.

[Adamant36]

So just to recap

Tomasz-W symmetrical

Tomasz-W asymmetrical version 1

Tomasz-W asymmetrical version 2

lakedistrictOSM pixel aligned symmetrical

[kocio-pl]

I like @Tomasz-W versions because of these nice details on packages. Probably asymmetrical v2 is nice, because it shows more diversity between packages, but all the icons here are good enough. My preference list goes as follows:

1. asymmetrical v2
2. asymmetrical v1
3. symmetrical v1 (@Tomasz-W )
4. symmetrical v2 (@lakedistrictOSM )

but I have harder problems to solve and leave it just as a hint. Whatever you will decide this this icon is OK for me.

[Adamant36]

@kocio-pl OK. Thanks.

@Tomasz-W and @lakedistrictOSM What do you both think?

[Tomasz-W]

@Adamant36 It's always harder to rate effect of your own work, so I believe in @kocio-pl "ranking" ;) . I've made v2 version, because v1 to be pixel-aligned has to have a tape shape in weird position, so I think my v2 without it might be even better.

[polarbearing]

asymmetrical v2 works best for me too, and I agree to use the icon for wholesale as well.

[lakedistrictOSM]

They're all readable for me. The labels on Tomasz-W's designs are a nice touch.

[Adamant36]

@kocio-pl If I add something new that is semi major to a PR like I am doing here by adding shop=wholesale is it usually the policy to add another commit for it and update the commit message to reflect it? Or do I just push the change, leave all the commit stuff the same, with a single commit, and mention it in the originally message?

[kocio-pl]

There's no policy for that. I guess if you enhance the title it should be enough, I just will wait a bit longer to not take anyone willing to comment by surprise.

[Adamant36]

@kocio-pl It should be good to go now. I left the icon name as trade for both of them because I couldn't come up with anything better. Also, I didn't upload test photos of the new trade icon for shop=trade, but I did test it on my end just in case and it works fine.

[kocio-pl]

Thanks! My independent tests are also OK.