-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add icon for shop=massage #3309
Conversation
After merging #3293 this code needs to be updated to resolve conflicts. |
Done :) |
I see why there is an small icon at z17. But before to make changes, I would like to know whether we leave a dot for z17 like other shops or we bypass rendering for z17 ? |
I think that we should bypass rendering at z17. z18 is good enough for massage places. Purple would be the wrong colour and green dots aren't yet used (and also might look like trees). |
I guess it's safe to render from z18. I don't have good idea for not typical colors of shops - BTW similar problem is with |
Could you update the code once again? I plan to merge it soon. BTW: please, add some line breaks aligned to the lines above, so the code is more readable and easier to edit. |
Done, I also put some line breaks as suggested. Is it correct for you ? |
Thanks, this is good! |
Fixes #3287
Changes proposed in this pull request:
Render
shop=massage
from z18 using leisure-green colourTest rendering with links to the example places:
Node
https://www.openstreetmap.org/node/4992712423
Way
https://www.openstreetmap.org/way/183708628