-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jewish symbols made lighter #2761
Conversation
Looks not bad to me. Could link or post an image with the symbol before? Would make it easier for me to compare. |
I have updated both images with before/after renderings. I'm not sure now about cemetery. With new symbol |
The general jewish religion symbol „after“ looks much clearer to me than the „before“ version. It can be recognized as Star of David. About the cemetery symbol: Honestly, both, the „before“ and the „after“ variant, I cannot reliably recognize them as Star of David. They are just to small. But the „after“ variant – even though stronger – seems to me easier to guess as Star of David. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to concur with @sommerluk.
Although i would assume this is clear but just in case it is not - this demonstrates the incorrect but consistent case described in #2750. |
Sorry, I don't understand it - could you describe in short words what exactly is incorrect and what do you think is consistent with this case? Any ideas what should be done to make it OK for you? |
The results in your After example above are not a faithful rendition of the SVG file, you can easily see this by comparing these results with a rendering of the pattern with other programs (Inkscape or ImageMagick) or with Mapnik when using Incorrect but consistent refers to what i wrote in #2750:
I don't know a way to fix this - otherwise i would have mentioned this in #2750. |
It looks like people are in favour of this rendering not because it's rendered similar to a vector image, but because it works better (in a cartographic sense) than current PNG image for them - and for me too. Solving the problem with Mapnik might give us the ultimate solution to this problem, but this PR would still make a progress with readability and fixes problem with map scaling, so it's worth merging IMO. |
Follow up to #2714 (comment).
Mapnik seems to render SVG in its own way, which is beyond our control and sometimes makes details to vanish, as it is with our current star of David. We can however try a symbol with thinner lines.
I took star_of_david3.svg from jsdotpattern project. It's rather not pixel aligned, but general religion symbol looks now better, because holes are visible. Cemetery symbol (the same shape scaled down to 10x9 px) is still worse than PNG (no small holes inside), so I would probably not use it:
Before
After
Before
After