Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shop=tyres rendering #2662

Merged
merged 1 commit into from
Jul 25, 2017
Merged

Adding shop=tyres rendering #2662

merged 1 commit into from
Jul 25, 2017

Conversation

kocio-pl
Copy link
Collaborator

Related to #2619

shop=tyres is the last of very popular shop types - above 10k uses - which have no special icon (the other one is shop=boutique, but it was rejected 2 years ago). This icon was designed by @MaestroGlanz and I find it good enough for this style:

slrr2van

@kocio-pl
Copy link
Collaborator Author

Any comments/reviews about it?

@daganzdaanda
Copy link

I cleaned the icon a bit and made it 12px tall to leave 1 px margin in a 14 px icon. Was that the way the other icons were sized?? It seems very tiny... https://gist.github.com/daganzdaanda/d0e644e0fa1844597f800d0aedddc372

@pnorman
Copy link
Collaborator

pnorman commented Jul 10, 2017

It kind of looks like there's a perspective to the icon, although that could also be a tyre on the left and a rim on the right.

@kocio-pl
Copy link
Collaborator Author

@daganzdaanda No, most of the icons are using 14px matrix, so you don't have to resize it.

@kocio-pl
Copy link
Collaborator Author

At 14px original proposition (1) looks more readable for me than the new one (2), so I left this code unchanged:

  1. tyres
  2. tyres2

I think in this case it's hard to avoid perspective at all. We've used it also for optic and book icon for the same reason.

@kocio-pl kocio-pl mentioned this pull request Jul 23, 2017
@kocio-pl
Copy link
Collaborator Author

I have trouble deciding about merging this code. "A pull request should have at least one review before it is merged" (#2436 (comment)) - but do we need formal review (like this one) or any comment indicating that other developer have seen it (like this)?

The problem is lack of review or reaction is common situation with our PRs, so decision making process is still not quite effective.

@nebulon42
Copy link
Contributor

For me this means a formal review.

Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the second icon shown, as I find it just as clear, and fits with our style guidelines.

@kocio-pl
Copy link
Collaborator Author

I doubt there's any difference in how both of them apply style guidelines, but reworked icon is also acceptable for me:

aeco qrc

@kocio-pl kocio-pl merged commit 7c3725b into gravitystorm:master Jul 25, 2017
@kocio-pl kocio-pl deleted the tyres branch July 25, 2017 01:01
@kocio-pl kocio-pl restored the tyres branch July 25, 2017 01:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants