Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish different cranes types #3573

Closed
Tomasz-W opened this issue Dec 15, 2018 · 4 comments
Closed

Distinguish different cranes types #3573

Tomasz-W opened this issue Dec 15, 2018 · 4 comments
Labels
declined new features Requests to render new features POI

Comments

@Tomasz-W
Copy link

Tomasz-W commented Dec 15, 2018

Follow up for #3478 and #3501. Distinguish different cranes types to show people better what they can expect in certain place.

  • man_made=crane + crane:type=portal_crane:
  • man_made=crane + crane:type=floor-mounted_crane:
    or (generic icon)
  • man_made=crane + crane:type=travel_lift and crane:type=gantry:

Gist link: https://gist.github.com/Tomasz-W/ed6c01e147616e786faff2690fcce686

@Tomasz-W Tomasz-W changed the title Distinguish differen cranes types Distinguish different cranes types Dec 15, 2018
@kocio-pl kocio-pl added the new features Requests to render new features label Dec 15, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Dec 15, 2018
@matthijsmelissen
Copy link
Collaborator

This is going in too much detail for this stylesheet. Icons are meant to be pictograms, and do not need to be a literal depiction of the object in question.

@Adamant36
Copy link
Contributor

@matthijsmelissen, you know that could apply to 99% of the icons being used right? For me its less about adding a "literal depiction of the object" and more about incentivising sub tagging by giving the sub tags their own icons. Which I think this accomplishes.

Also, I would venture that in a lot of cases people don't even know a sub tag exists or look it up on the wiki without it having unique icons. Personally, I wouldn't know about a lot of the sub-tags if there wasn't "to much detail" on the map by them having icons (different types of tourist information mediums comes to mind).

@sommerluk
Copy link
Collaborator

Let me add to what @matthijsmelissen said that the subtypes have all lower usage than 1000.

Closing as per @matthijsmelissen

@Adamant36
Copy link
Contributor

@Sommerluck, crane:type=gantry has 864 uses. Alone I doubt that the extra 136 uses to get it to 1000 really matters, but since its being combined with crane:type=travel_lift which has 327 uses its over 1000. So I'll probably do a PR on it anyway even if this issue is closed. For good measure I'll add crane:type=portal_crane to it also since it has 991 uses. You and @matthijsmelissen can feel free to split hairs over the missing 9 uses in that case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
declined new features Requests to render new features POI
Projects
None yet
Development

No branches or pull requests

6 participants