-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add rendering for man_made=crane #3478
Comments
It's OK for me. |
Notice also that this icon should match very different types of cranes, e.g. portal crane or gantry crane. |
Is there a link to the svg?
…On Sat, Oct 27, 2018 at 5:18 AM Tomasz Wójcik ***@***.***> wrote:
Notice also that this icon should match very different types of cranes,
e.g. portal crane
<https://www.google.pl/search?q=portal+crane&client=opera&hs=xiq&source=lnms&tbm=isch&sa=X&ved=0ahUKEwjSqYGD9aTeAhXFZ1AKHZbbDhYQ_AUIDigB&biw=1920&bih=977>
or gantry crane
<https://www.google.pl/search?q=gantry+crane&client=opera&hs=s3V&source=lnms&tbm=isch&sa=X&ved=0ahUKEwj1ptOJ9aTeAhWPHsAKHW26DrwQ_AUIDigB&biw=1920&bih=977>
.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3478 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshDCl3pyxHA76PtPbpfjCfIHy6CDlks5uo239gaJpZM4X5Is8>
.
|
crane:type=portal_crane 900
crane:type=Container_crane 474
crane:type=Gantry_crane 282
crane:type=Travellift=231
Vs 6000 cranes globally, so probably one icon is best for now.
On Sat, Oct 27, 2018 at 11:37 AM Joseph Eisenberg <
[email protected]> wrote:
… Is there a link to the svg?
On Sat, Oct 27, 2018 at 5:18 AM Tomasz Wójcik ***@***.***>
wrote:
> Notice also that this icon should match very different types of cranes,
> e.g. portal crane
> <https://www.google.pl/search?q=portal+crane&client=opera&hs=xiq&source=lnms&tbm=isch&sa=X&ved=0ahUKEwjSqYGD9aTeAhXFZ1AKHZbbDhYQ_AUIDigB&biw=1920&bih=977>
> or gantry crane
> <https://www.google.pl/search?q=gantry+crane&client=opera&hs=s3V&source=lnms&tbm=isch&sa=X&ved=0ahUKEwj1ptOJ9aTeAhWPHsAKHW26DrwQ_AUIDigB&biw=1920&bih=977>
> .
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub
> <#3478 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AoxshDCl3pyxHA76PtPbpfjCfIHy6CDlks5uo239gaJpZM4X5Is8>
> .
>
|
I believe cranes can render based on height, as with as towers. The "height" tag is not as common with cranes as with towers, but it can range from as little as 6 meters (2 storeys) to over 120 meters. About 170 are tagged with height so far. The smaller cranes may be at industrial buildings or rail yards in cities, where it would not be appropriate to display them at z15, but a 120 meter tall crate at a seaport can be shown as early as z14 with no problems. Name labels and cranes without height tagged would display at z17.
Most cranes are in big rail yards or ports, like the port in Singapore: https://www.openstreetmap.org/#map=17/1.2655/103.7928 Rail yards provide the possibility for cranes to be in the center of an urban area, such as this 128 meter tall crane in right next to the Porta Garibaldi train station in Milan, Italy. This is probably the most extreme example in the database: https://www.openstreetmap.org/#map=15/45.4851594/9.1832991 But most cranes are going to be on the edge of urban areas in industrial lands or along rivers and coasts: z17 other (no height tagged) cranes visible Port of Santiago, Cuba: https://www.openstreetmap.org/#map=15/20.0252605/75.8440889 River port crane with name, Blauer Kran, height 24m: Small river crane with name, height 12m: Crane on a closed way with name label at z17: I just need an .svg version of the icon to finish the code, if others believe this is ready for a PR |
Great piece of research, nice to see such evidence based design! I think this is ready for PR as soon as vector icon is available. |
Lovely :-) |
After wider research I decided to design dedicated icons for each crane type:
Gist link: https://gist.github.com/Tomasz-W/ed6c01e147616e786faff2690fcce686 |
For gantry crane can we use the same icon as portal crane? It seems like
they are the same on the wiki page, and the icon looks like a gantry crane,
I think? Wikipedia says gantry and portal are used interchangeably
…On Sat, Oct 27, 2018 at 6:10 PM Tomasz Wójcik ***@***.***> wrote:
After wider research I decided to design dedicated icons for each crane
type:
- generic man_made=crane:
[image: man_made crane]
<https://user-images.githubusercontent.com/25656654/47601358-c7e60b80-d9cf-11e8-972e-8cdcc138d681.png>
- man_made=crane + crane:type=portal_crane:
[image: man_made crane portal]
<https://user-images.githubusercontent.com/25656654/47601256-31651a80-d9ce-11e8-8050-c997a67dd9ca.png>
- man_made=crane + crane:type=floor-mounted_crane:
[image: man_made crane floor]
<https://user-images.githubusercontent.com/25656654/47602005-9d4c8080-d9d8-11e8-8bd1-bedc3bea63f5.png>
- man_made=crane + crane:type=travel_lift:
[image: man_made crane travel]
<https://user-images.githubusercontent.com/25656654/47601758-88222280-d9d5-11e8-9c98-c231d61e2a16.png>
Gist link:
https://gist.github.com/Tomasz-W/ed6c01e147616e786faff2690fcce686
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3478 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshIAKwCtqsx5sWhtdqsuHeYjObcxoks5upCLngaJpZM4X5Is8>
.
|
@jeisenbe As |
What is the distinction between a gantry_crane, a portal_crane, and a travel_lift? I couldn't find a good definition. |
@jeisenbe I've recently updated Wiki page to make things more clear, see: |
For now, I'd just use one icon for all crane types. The generic crane icon is the best one. Although cranes are very tall, they tend to have small footprints so I'd skip rendering at z14. |
The tall ones are also quite long, especially those at sea ports. The huge
post-Panamax cranes have to be big enough to cover an 18-container wide
ship over the water. I believe a 100m tall crane will usually be about 100m
long.
We currently render 100 meter man_made=tower at z14, and these usually have
smaller footprints than cranes.
…On Sat, Oct 27, 2018 at 11:31 PM lakedistrictOSM ***@***.***> wrote:
For now, I'd just use one icon for all crane types. The generic crane icon
is the best one.
Although cranes are very tall, they tend to have small footprints so I'd
skip rendering at z14.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3478 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshLVysifMqVDgCOSL6IQ-UUOar4AAks5upG47gaJpZM4X5Is8>
.
|
same question: why not using the |
It was black because I was testing with a png instead of an svg. With the
svg it should render properly. I’d show some examples, but both of my
laptops are refusing to start up.
…On Mon, Oct 29, 2018 at 5:54 PM Jérémy Ragusa ***@***.***> wrote:
same question: why not using the @man-made-icon color instead of black ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3478 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AoxshNFZ-Y_T_Tsr9jRUixpzkFCyHIKzks5upsIqgaJpZM4X5Is8>
.
|
Why cranes do not appear rendered in OSM?
Wiki: https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dcrane
Examples: https://www.openstreetmap.org/node/6000837250
The text was updated successfully, but these errors were encountered: