Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rendering for man_made=crane #3478

Closed
Ti4goc opened this issue Oct 24, 2018 · 18 comments · Fixed by #3501
Closed

Add rendering for man_made=crane #3478

Ti4goc opened this issue Oct 24, 2018 · 18 comments · Fixed by #3501
Labels
new features Requests to render new features POI
Milestone

Comments

@Ti4goc
Copy link

Ti4goc commented Oct 24, 2018

Why cranes do not appear rendered in OSM?

Wiki: https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dcrane

Examples: https://www.openstreetmap.org/node/6000837250

@kocio-pl kocio-pl added the new features Requests to render new features label Oct 24, 2018
@kocio-pl kocio-pl added this to the New features milestone Oct 24, 2018
@kocio-pl
Copy link
Collaborator

We need an icon for that, but the usage is OK:

taghistory 18

@kocio-pl kocio-pl changed the title Add rendering for Tag:man_made=crane Add rendering for man_made=crane Oct 24, 2018
@Tomasz-W
Copy link

man_made=crane icon proposal:

man_made crane

@kocio-pl
Copy link
Collaborator

It's OK for me.

@Tomasz-W
Copy link

Notice also that this icon should match very different types of cranes, e.g. portal crane or gantry crane.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 27, 2018 via email

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 27, 2018 via email

@jeisenbe
Copy link
Collaborator

I believe cranes can render based on height, as with as towers. The "height" tag is not as common with cranes as with towers, but it can range from as little as 6 meters (2 storeys) to over 120 meters. About 170 are tagged with height so far.

The smaller cranes may be at industrial buildings or rail yards in cities, where it would not be appropriate to display them at z15, but a 120 meter tall crate at a seaport can be shown as early as z14 with no problems. Name labels and cranes without height tagged would display at z17.

    [zoom >= 13][height >= 100],
    [zoom >= 14][height >= 50],
    [zoom >= 15][height >= 30],
    [zoom >= 16][height >= 15],
    [zoom >= 17] {

Most cranes are in big rail yards or ports, like the port in Singapore: https://www.openstreetmap.org/#map=17/1.2655/103.7928
z16 no cranes visible (no heights tagged); but they would be lining the waterfront. I hope mappers will add height tags later so that they will render earlier.
singapore-z16

z17 cranes visible
singapore-z17

Rail yards provide the possibility for cranes to be in the center of an urban area, such as this 128 meter tall crane in right next to the Porta Garibaldi train station in Milan, Italy. This is probably the most extreme example in the database: https://www.openstreetmap.org/#map=15/45.4851594/9.1832991
z14
milano-z14

z15
milano-z15

z16
milano-z16

But most cranes are going to be on the edge of urban areas in industrial lands or along rivers and coasts:
Port of Venice, Italy: https://www.openstreetmap.org/#map=15/45.4729014/12.2435279
z14 largest >100m cranes visible
venice-z14small

z15
venice-z15

z16
venice-z16

z17 other (no height tagged) cranes visible
venice-z17

Port of Santiago, Cuba: https://www.openstreetmap.org/#map=15/20.0252605/75.8440889
z15 largest 60m crane visible (there are two but one is blocked by the other)
cuba-z15

z17 other cranes visible
cuba-z17

River port crane with name, Blauer Kran, height 24m:
https://www.openstreetmap.org/#map=16/50.1129065/8.7519599

z15 icon
blauerkran26m-z15

z16
blauerkran26m-z16

z17 icon and name label
blauerkran26m-z17

Small river crane with name, height 12m:
https://www.openstreetmap.org/#map=17/51.2551612/6.741607
z16 not visible
bigwilli-z16

z17 icon and name label
bigwilli12m-z17

Crane on a closed way with name label at z17:
https://www.openstreetmap.org/#map=17/50.1131957/8.7441295
http://openstreetmap.org/way/282295510
z17
evo-z17

I just need an .svg version of the icon to finish the code, if others believe this is ready for a PR

@kocio-pl
Copy link
Collaborator

Great piece of research, nice to see such evidence based design! I think this is ready for PR as soon as vector icon is available.

@polarbearing
Copy link
Contributor

Lovely :-)

@Tomasz-W
Copy link

Tomasz-W commented Oct 27, 2018

After wider research I decided to design dedicated icons for each crane type:

  • generic man_made=crane:
    man_made crane
  • man_made=crane + crane:type=portal_crane:
    man_made crane portal
  • man_made=crane + crane:type=floor-mounted_crane:
    man_made crane floor
  • man_made=crane + crane:type=travel_lift or crane:type=gantry:
    man_made crane travel

Gist link: https://gist.github.com/Tomasz-W/ed6c01e147616e786faff2690fcce686

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 27, 2018 via email

@Tomasz-W
Copy link

@jeisenbe As gantry_crane is quite popular type, but it's not added to Wiki list, I'll add it. Anyway, for gantry cranes I would use a travel_lift icon (it's a kind of gantry crane with a wheels under it). I'll also do a clean up of some tagging mistakes, because on TagInfo I can see some tags duplicated.

@jeisenbe
Copy link
Collaborator

What is the distinction between a gantry_crane, a portal_crane, and a travel_lift? I couldn't find a good definition.

@Tomasz-W
Copy link

@jeisenbe I've recently updated Wiki page to make things more clear, see:

https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dcrane

@lakedistrictOSM
Copy link

For now, I'd just use one icon for all crane types. The generic crane icon is the best one.

Although cranes are very tall, they tend to have small footprints so I'd skip rendering at z14.

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 28, 2018 via email

@jragusa
Copy link
Contributor

jragusa commented Oct 29, 2018

same question: why not using the @man-made-icon color instead of black ?

@jeisenbe
Copy link
Collaborator

jeisenbe commented Oct 29, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new features Requests to render new features POI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants