-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SVG metadata and performance #3393
Comments
The deploy (this is not handled in this repo) could sanitize all svgs. |
Fine, but this style is inherited by other projects as well (e.g. German style). |
Thanks for raising this issue. I also noticed, that there are dozens of different SVG code schemes in our files, and I'm also interested, does the longest ones are causing some problems. As I'm not a tech guy but designer, I rather won't help technically, but I thought - maybe there is possibility of some converter, which would make output files short as possible? |
Good call @polarbearing. If someone wants to cleanup/unify the icon schemes id be willing to add the improved icons to the pixel alignment PR. It sounds like something that would be worth doing. |
Never mind. The pixel alignment PR just got merged. |
@polarbearing hails from the OSM hackweekend in Berlin. Discussed the issue with our friend from OSMbuildings, he has an example for a minimal svg here. Just tested that, it loads fine in Ad$be Ill$str$t$r. Even the first There are some SVG cleaners flying around, some of them open source. Somebody willing to test? How does this travis thing here work, would that be a hook to automate the cleaning? |
Image editing software often leaves a lot of metadata in the SVG code. In the icons I submitted, I usually took a text editor and cleaned everything that apparently does not contribute to the icon shape.
I don't know if it is worth the effort. It makes the SVG code a bit more human-readable and shrinks the size about 50%, but we talk about small files already. On the other hand some of these files are used quite often in the rendering.
Thus it would be interesting if somebody could investigate if that has any influence on the performance, thus it should be generally recommended.
Example of meta code:
The text was updated successfully, but these errors were encountered: