-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pixel aligning some icons #3362
Comments
👍 Other icons in need of alignment that have been on my radar are:
|
@meased I've checked icons which you have mentioned, most of them was mostly pixel-aligned (it's impossible to do a full pixel-aligning, because it's not a Minecraft ;) ). As hotel icon was not pixel aligned, and other accomodation types has copied bed shape from this icon, I fixed them all: Gist link: https://gist.github.com/Tomasz-W/7b26018d9224f3c53b033e28a568a724 @kocio-pl Do you agree that pixel aligned versions of all icons are better? Which one of @Adamant36 It would be rather easy PR to do, because it's only icon files change. Would you like to take care of it? |
@Tomasz-W The thin version of the info board is better. |
I also like the thin version of the info board. I would like to see rendering especially of wayside_shrine and atm to know the difference. It's good to remember that post box has the same slot shape, so maybe it should be tweaked too. |
Sure. I'll do it after the other PRs I'm working on get done and the icons get figured out. |
@kocio-pl Post box hava a similar slot shape (round corners), but it's a 1px wide, so difference between proposed atm icon (with sharp corners) would be unvisible in this part. |
Maps that are mapped in OSM are not movable and not foldable. The wiki says it's a
Therefore the current icon is a bit inappropriate / misleading. What about an icon with a board with a map, something like . This is a bit harder to distinguish from the icon for an information board: , but that's how it's also in real life; some boards contain written information and also a map. |
I prefer clear symbol (which sometimes is not 1:1 to reality) than trying to be correct but too complex and not clear. |
Agree with @kocio-pl. Icons are symbolic, not miniature depictions of real life. |
@kocio-pl What do you think about current |
I agree. It has nothing to do with payment card, it's about showing things according to their size: |
sent from a phone
On 29. Aug 2018, at 16:12, kocio-pl ***@***.***> wrote:
I agree. It has nothing to do with payment card, it's about showing things according to their size:
I don’t agree with the idea that showing an atm (or when to show it) has to do with its size
|
What are your arguments and (more important) what's your proposition? |
@Tomasz-W, is this ready to go? Good job btw. The new icons look way better. |
@Adamant36 Yes, it's ready. |
Good effort! Should we consider #3393 here already (cleaning metadata)? |
Some of icons which I have designed at the beginning of my activity here, was not pixel-aligned, but we have added them anyway. Now I fixed them and reuploaded to Gist.
I also propose to make a line in
amenity=atm
icon thinner to make it less prominent.(Current icon on the left, fixed icon(s) on the right)
historic=wayside_shrine
Gist: https://gist.github.com/Tomasz-W/e237875a860653546d553cacd4d8afbd
amenity=bbq
Gist: https://gist.github.com/Tomasz-W/4ff000df11e004abf24d5e77f5b8db62
information=audioguide
Gist: https://gist.github.com/Tomasz-W/c1b01647b8979e88b14d3dee6fcb3138
information=board
[I prefer thin version]Gist: https://gist.github.com/Tomasz-W/d6f962425fbc8ec05b54a696e7eaee66
information=map
Gist: https://gist.github.com/Tomasz-W/1e8f2e4a59069ddee99db53ac1a5c1dc
shop=ticket
Gist: https://gist.github.com/Tomasz-W/b18eee2375829d1fa2e97f40fd855968
tower:type=bell_tower
Gist: https://gist.github.com/Tomasz-W/18d5cac547924610245808723dd61319
amenity=atm
Gist: https://gist.github.com/Tomasz-W/bcb011d2e8785553241f63121adf307d
The text was updated successfully, but these errors were encountered: