Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pixel aligning some icons #3362

Closed
Tomasz-W opened this issue Aug 23, 2018 · 16 comments · Fixed by #3383
Closed

Pixel aligning some icons #3362

Tomasz-W opened this issue Aug 23, 2018 · 16 comments · Fixed by #3383

Comments

@Tomasz-W
Copy link

Some of icons which I have designed at the beginning of my activity here, was not pixel-aligned, but we have added them anyway. Now I fixed them and reuploaded to Gist.
I also propose to make a line in amenity=atm icon thinner to make it less prominent.

(Current icon on the left, fixed icon(s) on the right)

@meased
Copy link
Contributor

meased commented Aug 23, 2018

👍

Other icons in need of alignment that have been on my radar are:

  • tourism=motel
  • amenity=car_rental
  • amenity=bicycle_rental
  • shop=car_repair
  • shop=car
  • amenity=car_wash

@kocio-pl kocio-pl added the bug label Aug 23, 2018
@kocio-pl kocio-pl added this to the Bugs and improvements milestone Aug 23, 2018
@Tomasz-W
Copy link
Author

Tomasz-W commented Aug 25, 2018

@meased I've checked icons which you have mentioned, most of them was mostly pixel-aligned (it's impossible to do a full pixel-aligning, because it's not a Minecraft ;) ). As hotel icon was not pixel aligned, and other accomodation types has copied bed shape from this icon, I fixed them all:

  • tourism=apartament
    apartament pobrany plik apartament
  • tourism=guest_house
    guest house pobrany plik guest house
  • tourism=hostel
    hostel pobrany plik hostel
  • tourism=hotel
    hotel pobrany plik hotel
  • tourism=motel
    motel clean svg tourism motel

Gist link: https://gist.github.com/Tomasz-W/7b26018d9224f3c53b033e28a568a724

@kocio-pl Do you agree that pixel aligned versions of all icons are better? Which one of information=board do you prefer?

@Adamant36 It would be rather easy PR to do, because it's only icon files change. Would you like to take care of it?

@lakedistrictOSM
Copy link

@Tomasz-W The thin version of the info board is better.

@kocio-pl
Copy link
Collaborator

I also like the thin version of the info board. I would like to see rendering especially of wayside_shrine and atm to know the difference. It's good to remember that post box has the same slot shape, so maybe it should be tweaked too.

@Adamant36
Copy link
Contributor

Sure. I'll do it after the other PRs I'm working on get done and the icons get figured out.

@Tomasz-W
Copy link
Author

@kocio-pl Post box hava a similar slot shape (round corners), but it's a 1px wide, so difference between proposed atm icon (with sharp corners) would be unvisible in this part.

@Hufkratzer
Copy link

Maps that are mapped in OSM are not movable and not foldable. The wiki says it's a

board with a map

Therefore the current icon folded is a bit inappropriate / misleading. What about an icon with a board with a map, something like 14map_board. This is a bit harder to distinguish from the icon for an information board: board1px, but that's how it's also in real life; some boards contain written information and also a map.

@kocio-pl
Copy link
Collaborator

I prefer clear symbol (which sometimes is not 1:1 to reality) than trying to be correct but too complex and not clear.

@meased
Copy link
Contributor

meased commented Aug 26, 2018

Agree with @kocio-pl. Icons are symbolic, not miniature depictions of real life.

@Tomasz-W
Copy link
Author

@kocio-pl What do you think about current amenity=atm zoom level (17)? I think it's too early for such a small feature, and it should be moved higher, maybe even to only z19, but as I don't have payment card I might be wrong.

@kocio-pl
Copy link
Collaborator

I agree. It has nothing to do with payment card, it's about showing things according to their size:

https://www.openstreetmap.org/user/kocio/diary/44852

@dieterdreist
Copy link

dieterdreist commented Aug 30, 2018 via email

@kocio-pl
Copy link
Collaborator

What are your arguments and (more important) what's your proposition?

@Adamant36
Copy link
Contributor

@Tomasz-W, is this ready to go? Good job btw. The new icons look way better.

@Tomasz-W
Copy link
Author

Tomasz-W commented Sep 9, 2018

@Adamant36 Yes, it's ready.

@polarbearing
Copy link
Contributor

Good effort! Should we consider #3393 here already (cleaning metadata)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants