-
Notifications
You must be signed in to change notification settings - Fork 829
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display platform numbers (ref=* of railway=platform) #3271
Comments
We're currently rendering name, so how do you think it should be rendered, ref instead of name or in any other way? |
I'd say ref instead of name because the name of the station is already rendered. |
Suppose it's a question of whether platforms should be displayed as "Platform X" like here: https://www.openstreetmap.org/#map=19/55.95148/-3.19063 (using name=) I'd say it's better with simply their number, in which case osm-carto should render ref instead of name - it would also prevent people tagging for the renderer currently using the name tag. |
Sounds reasonable for me. Would any of you like to prepare the code? |
I'd like to help, but unfortunately I have only little programming knowledge. :-( |
Me too, so that should not be a problem in many cases, it's rather pattern copying and slightly changing them. The problem is we lack coders in this project, so until somebody actually do it, there's little chance to resolve it. |
Theres a way text from multiple fields can be displayed in labels with brackets I was just reading about. Maybe that would be an option. The code for it and an example is about half day down in the link. |
In France, Germany and Switzerland, ref platform are displayed white in a blue square. We could use the blue square of railway station as a shield like for ref label of road. Once restrained to z19 (z18?) this would not disturb the map and this allows to add the name tag if the latter is different. |
I had a look on overpass-turbo for platforms with names in the UK and noticed a couple of things. Ways with name=* are not rendered, whereas closed ways with names (and area=yes) are rendered. Most platforms which have ref=and name= can be described as follows:
So in terms of tagging, should names even be used if they are mostly just duplicating the ref? |
My two pennies' worth: |
@kocio-pl I searched the code for "platform" and also looked at other places mentioning "railway", but can't find where the code is which actually renders the name. There is Line 2132 in 1419ef8
Plus there's the issue of why name=* renders on an area, but not on a single line. |
Platform text rendering is handled as a roads-area-text-name, which only renders the name on an area over 3000px. To separate this out without retagging requires an exception, but at the moment doing so will remove labels where they are tagged with name. |
I don't think it will take that long to retag the platforms in OSM from name to ref - it shouldn't put you off switching the rendering from name to ref. Is there a way to make a platform like this - without area=yes - render like it has area=yes? |
I don't see why not, but I'm not sure that that's really the best way to tag platforms? Surely that should be marked as area=yes since it's an actual platform? |
Hmm you're probably right - and it would be better if an island platform was mapped as two separate ways so the ref tags can be added to each platform. It would be great if you were able to do a test render for this, and submit a PR :) Then we can start fixing the platforms in OSM by moving data from name to ref! |
Looking again it seems that name=* is not rendered unless the railway=platform is also tagged as area=yes. That's fine for detailed stations where platforms are mapped as a closed way, but not for those with just a line for a platform. So as well as switching from rendering name to ref, we also need to allow single ways to be rendered with the ref value. |
The rules for railway=platform should be the same as for golf=hole where the 'name' tag is rendered if present, otherwise the 'ref' tag is displayed (if present). |
I think it would be quite useful if platform numbers, i.e.
ref=*
ofrailway=platform
, were rendered.The text was updated successfully, but these errors were encountered: