-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize pictos of wood/forest and swamp/mangrove #1920
Comments
@imagico what do you think? |
2015-10-22 14:21 GMT+02:00 math1985 [email protected]:
I'm not imagico, but I clearly prefer the existing mangrove/swamp trees |
@dieterdreist But the current tree icon of mangrove could be modified to display more roots and still have the general shape of the current one, but smoother like the current tree icon of woods. This is what I wanted to ask, but it seems I didn't express myself the right way: it's not the general shape of the icon, just its smoothness; the current wood icon seems more uncluttered than the tree icon for mangrove and swamps. |
For mangrove i think there is neither a need or a good possibility for a change - the tree pairs do not make sense there (mangrove is always broadleaved). You could try to create a symbol closer design-wise to the pairs but i don't think this would look good. For swamp - yes, the paired symbols could be combined with the wetland pattern here. Practically broadleaved species are much more common in swamp environments than conifers (with few exceptions like the cypress swamps in the southern US). Maybe @SK53 has some further thoughts on that. |
Ah, I didn't speak clearly once again: I only thought to the broad-leaved tree icon, not the conifer one. Indeed, it would be useless and confusing to use both tree icons, but I only spoke about the broadleaved one. Regarding the design, IMHO, there is 2 issues:
Still, for mangroves, the base icon should be modified to show multiple roots, to depict the general appearance of such trees. |
@imagico Very quick response about leaf_type in swamp woodland. There are lots of boreal coniferous forests which are swamps. Muskeg is the example which comes to mind. Our two Russian mappers remarked when walking in woods near Karlsruhe that many northern woods are effectively swamps, which supports this. A quick google reveals at least one coniferous swamp vegetation type found as far S as Massachusetts (http://www.mass.gov/eea/docs/dfg/nhesp/natural-communities-facts/spruce-fir-boreal-swamp.pdf). I'll need to review some of the current rendering for further comments: I've certainly missed some of the detail in more recent changes to rendering wetland & mangroves. |
You are probably right although intuitively i would not consider boreal forests swamps. Many of these are seasonal wetlands being water saturated during spring thawing but drying up during summer. AFAIK many conifers, in particular Spruce, do not generally grow on permanently waterlogged soil. Here is the swamp pattern with the wood/forest symbol: |
What would it need to merge this in master? Replacing the current PNG, PR this and that's it? Just to know if I can do it without knowledge of the internals. |
Yes, it seems like a not too hard challenge technically. I wish this discussion was more conclusive, but there will be a chance to tune a PR before it will be merged. |
Thanks @imagico for the pattern
Thanks @imagico for the pattern
Thanks @imagico for the pattern
Thanks @imagico for the pattern
Prepared a PR for that; I had a hard time not mixing authors and using a branch for the PR, but it seems good now. |
* Uniformize swamp rendering with forest/wood (fixes #1920) Thanks @imagico for the pattern * Updated swamp.svg and regenerated patterns accordingly * Ajout pour mémoire des commandes utilisées pour génération * Finally generated a correct PNG pattern for swamps * Pixel-aligned and corrected gamma of swamp pattern
Hello, there.
Some weeks ago, the #1728 pull request changed the tree symbols used for
landuse=forest
andnatural=wood
for smoother ones:Now, I'm under the impression that the tree symbols used for
wetland=swamp
and
wetland=mangrove
should be updated too to use the same tree symbol for swamp, and a multiroot version for mangroves, as they are now different, the difference being visible as the tree symbol for wetlands is not as smooth as the one for wetlands.
Just saying…
Regards.
The text was updated successfully, but these errors were encountered: