Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize pictos of wood/forest and swamp/mangrove #1920

Closed
Penegal opened this issue Oct 22, 2015 · 11 comments · Fixed by #3051
Closed

Standardize pictos of wood/forest and swamp/mangrove #1920

Penegal opened this issue Oct 22, 2015 · 11 comments · Fixed by #3051

Comments

@Penegal
Copy link
Contributor

Penegal commented Oct 22, 2015

Hello, there.

Some weeks ago, the #1728 pull request changed the tree symbols used for landuse=forest and natural=wood for smoother ones:
forest

Now, I'm under the impression that the tree symbols used for wetland=swamp
swamp
and wetland=mangrove
mangrove
should be updated too to use the same tree symbol for swamp, and a multiroot version for mangroves, as they are now different, the difference being visible as the tree symbol for wetlands is not as smooth as the one for wetlands.

Just saying…

Regards.

@matthijsmelissen
Copy link
Collaborator

@imagico what do you think?

@dieterdreist
Copy link

2015-10-22 14:21 GMT+02:00 math1985 [email protected]:

@imagico https://github.com/imagico what do you think?

I'm not imagico, but I clearly prefer the existing mangrove/swamp trees
over those in the rendering above. Better looking (IMHO) and better
readable. And much more professional (there is the idea of spatial
extension / shadow / volume as well as being "earthed"/"grounded" that the
new trees are completely missing).

@Penegal
Copy link
Contributor Author

Penegal commented Oct 22, 2015

@dieterdreist But the current tree icon of mangrove could be modified to display more roots and still have the general shape of the current one, but smoother like the current tree icon of woods. This is what I wanted to ask, but it seems I didn't express myself the right way: it's not the general shape of the icon, just its smoothness; the current wood icon seems more uncluttered than the tree icon for mangrove and swamps.

@imagico
Copy link
Collaborator

imagico commented Oct 22, 2015

For mangrove i think there is neither a need or a good possibility for a change - the tree pairs do not make sense there (mangrove is always broadleaved). You could try to create a symbol closer design-wise to the pairs but i don't think this would look good.

For swamp - yes, the paired symbols could be combined with the wetland pattern here. Practically broadleaved species are much more common in swamp environments than conifers (with few exceptions like the cypress swamps in the southern US). Maybe @SK53 has some further thoughts on that.

@Penegal
Copy link
Contributor Author

Penegal commented Oct 22, 2015

Ah, I didn't speak clearly once again: I only thought to the broad-leaved tree icon, not the conifer one. Indeed, it would be useless and confusing to use both tree icons, but I only spoke about the broadleaved one. Regarding the design, IMHO, there is 2 issues:

  • the shape of the tree: for wetland, the trunk isn't meeting the two sides of the circle marking the branches, as on the wood/forest icon;
  • the line thickness varies for wetlands, unlike for woods and forests.

Still, for mangroves, the base icon should be modified to show multiple roots, to depict the general appearance of such trees.

@SK53
Copy link

SK53 commented Oct 22, 2015

@imagico Very quick response about leaf_type in swamp woodland. There are lots of boreal coniferous forests which are swamps. Muskeg is the example which comes to mind. Our two Russian mappers remarked when walking in woods near Karlsruhe that many northern woods are effectively swamps, which supports this. A quick google reveals at least one coniferous swamp vegetation type found as far S as Massachusetts (http://www.mass.gov/eea/docs/dfg/nhesp/natural-communities-facts/spruce-fir-boreal-swamp.pdf).

I'll need to review some of the current rendering for further comments: I've certainly missed some of the detail in more recent changes to rendering wetland & mangroves.

@imagico
Copy link
Collaborator

imagico commented Oct 22, 2015

You are probably right although intuitively i would not consider boreal forests swamps. Many of these are seasonal wetlands being water saturated during spring thawing but drying up during summer. AFAIK many conifers, in particular Spruce, do not generally grow on permanently waterlogged soil.

Here is the swamp pattern with the wood/forest symbol:

swamp with tree pairs

@Penegal
Copy link
Contributor Author

Penegal commented Jan 31, 2018

What would it need to merge this in master? Replacing the current PNG, PR this and that's it? Just to know if I can do it without knowledge of the internals.

@kocio-pl
Copy link
Collaborator

Yes, it seems like a not too hard challenge technically. I wish this discussion was more conclusive, but there will be a chance to tune a PR before it will be merged.

Penegal pushed a commit to Penegal/openstreetmap-carto that referenced this issue Feb 1, 2018
Penegal pushed a commit to Penegal/openstreetmap-carto that referenced this issue Feb 1, 2018
Penegal added a commit to Penegal/openstreetmap-carto that referenced this issue Feb 1, 2018
Penegal added a commit to Penegal/openstreetmap-carto that referenced this issue Feb 1, 2018
@Penegal
Copy link
Contributor Author

Penegal commented Feb 1, 2018

Prepared a PR for that; I had a hard time not mixing authors and using a branch for the PR, but it seems good now.

@Penegal
Copy link
Contributor Author

Penegal commented Feb 1, 2018

@imagico: there are comments you could answer on the #3051 PR.

imagico pushed a commit that referenced this issue Mar 6, 2019
* Uniformize swamp rendering with forest/wood (fixes #1920)

Thanks @imagico for the pattern

* Updated swamp.svg and regenerated patterns accordingly

* Ajout pour mémoire des commandes utilisées pour génération

* Finally generated a correct PNG pattern for swamps

* Pixel-aligned and corrected gamma of swamp pattern
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment