-
Notifications
You must be signed in to change notification settings - Fork 822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
render military areas and prisons on top of buildings and roads #1285
Comments
We don't, and we should :) |
I meant "we do want to". =} One more, but so basic thing, that I have even not checked - the geometry (hatching density and angle) is different... |
The angle is intentional, it is vertical on the prison (symbolising the bars), and 45 deg on the military. Please consider the optical illusion from the oblique buildings in your example if you don't see it vertical. The density is 3px line in a 16x16 png, both in the vertical and the 45 deg version, the perceived difference comes from the different angle. |
You are probably right about all those optical effects, however I'm skeptic if we want such distinction at all - I think the color+icon tandem is enough. In my view "cool" symbolism was taken not considering consistency of hatched areas. Nevertheless there's still the problem of layering - key options are:
On military area we have probably 1a - hatching above most objects except highways. Now we need to decide (and justify it somehow). I would say 1. is preferable to me. |
I need to add another landcover overlay for #1242 that lies above landcover but below buildings |
@jragusa Can you make a PR similar to #3469 for |
@Tomasz-W yes I will take a look this week |
1 month later... I moved the layer |
I'm not sure that is an improvement. I remember it was a conscious decision a while ago to keep the roads above the hatching and the outline.
|
Can the outline be gotten rid of or is it necessary for the hatching or something? That might be one solution. I know it makes it easier to make out the area at higher zoom levels, but the hatching and color might be enough on its own. Especially if similar colors like retail are moved away from having red tints. |
I realise that I need to resolve firstly this issue before to work on #688, otherwise buildings will also appear over |
The outline is probably independent of the hatching. But we are looking for more potential outlines, see #3045, thus the problem should be addressed. I'd assume roads are rendered relatively late, so it should not be too difficult to get the outline under it. It might help to clarify in what order things are desired to render here. |
I would render outlines over highways to make them constant and alle readable. Overlay should be an overlay. Examples of outlines "broken" by highways above: |
Rendering tourism outlines earlier was a concious decision in #3037 to solve the problem that the outline was hiding linear barriers. It was discussed at that stage that highways should paint over the outline. In the examples there are also several mapping errors, e.g. a toll booth at the zoo entrance (n261283122), or missing gates (it makes no sense to have one gate in the middle and free entrance left and right) |
We have inconsistent hatching rules for amenity=prison and landuse=military (I don't know if there are some other hatched objects right now): one is rendered as the lower layer than buildings, grass and parking, while the other is rendered above all these elements, but - as far as I can see - below the highways.
See the example here:
https://www.openstreetmap.org/#map=19/52.20806/21.01130
Do we want to have general rules for layering hatchings (I guess we do) and how should they be defined - or maybe we want to express something by using different patterns?
The text was updated successfully, but these errors were encountered: