Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hostel icon not rendered on recreation_ground #1232

Closed
2 tasks done
polarbearing opened this issue Jan 16, 2015 · 4 comments
Closed
2 tasks done

Hostel icon not rendered on recreation_ground #1232

polarbearing opened this issue Jan 16, 2015 · 4 comments
Labels
amenity-points
Milestone
Bugs and improvem...

Comments

@polarbearing
Copy link
Contributor

tourism=hostel + landuse=recreation ground is a typical combination for bungalow villages.
http://overpass-turbo.eu/s/73y

Usually the label is written in the landuse style, thus the hostel icon is not rendered.
In the case the map is centred to, the playground node in the centre seems to block any label or icon.

Shouldn't *-placement = interiour also look for positions that are not in the centre?

Edit by @math1985:

  • Recreation ground names have higher priority than hostel names
  • The playground icon blocks the rendering of the hostel name
@pnorman
Copy link
Collaborator

pnorman commented Jan 16, 2015

Shouldn't *-placement = interiour also look for positions that are not in the centre?

No, I don't believe point symbolizers will try multiple locations without explicitly setting the other locations, which is not possible in CartoCSS without some hackish workarounds.

@polarbearing
Copy link
Contributor Author

Should a tourism or amenity label be written with higher priority than the landuse (in particular as they have the same size)?

@polarbearing polarbearing mentioned this issue Jan 30, 2015
Closed
@matthijsmelissen matthijsmelissen added this to the Bugs and improvements milestone Feb 2, 2015
@matthijsmelissen
Copy link
Collaborator

There are two issues here:

  • Recreation ground names have higher priority than hostel names
  • The playground icon blocks the rendering of the hostel name

matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
aa53e41 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
@matthijsmelissen matthijsmelissen mentioned this issue Mar 4, 2015
Merged
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
4a3dfaf 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 4, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
4933cdb 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
matthijsmelissen added a commit to matthijsmelissen/openstreetmap-carto that referenced this issue Mar 9, 2015
@matthijsmelissen
Resolve bugs related to COALESCE problems
f93b782 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
sommerluk pushed a commit to sommerluk/openstreetmap-carto that referenced this issue Mar 16, 2015
@matthijsmelissen @sommerluk
Resolve bugs related to COALESCE problems
fa1128f 
* Make sure conditions are checked in both WHERE and COALESCE
  Checking the condition in the WHERE class is necessary for performance.
  Checking the condition in the COALESCE is necessary to prevent unrendered tags
  blocking rendering of tags further down in the COALESCE.
  See also the discussion [here](gravitystorm#1038 (comment)).

  This is an improvement of gravitystorm#1038.

  This resolves gravitystorm#985, resolves gravitystorm#1029, resolves gravitystorm#1336.

* Give amenity priority over shop.

  This resolves gravitystorm#963.

* Give tourism priority over amenity, shop, leisure, landuse, man_made, natural,
  and place.

  This resolves gravitystorm#1269, resolves first issue of gravitystorm#1232.
@matthijsmelissen
Copy link
Collaborator

The playground icon blocks the rendering of the hostel name

This is duplicate with #964.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
amenity-points
Projects
None yet
Milestone
Bugs and improvements
Development

No branches or pull requests
3 participants
@pnorman @matthijsmelissen @polarbearing