fix: upgrade storybook version to 9.1.20#2665
Closed
qradle-yndx wants to merge 1 commit into
Closed
Conversation
qradle-yndx
requested review from
Alutery,
Arucard89,
DakEnviy,
DaryaLari,
Estasie,
IsaevAlexandr,
KostyaAvtushko,
Lunory,
Marginy605,
NasgulNexus,
NikitaCG,
Raubzeug,
Ruminat,
ValeraS,
Vladeeg,
amje,
bityutskiyAO,
d3m1d0v,
dvortsovs,
goshander,
igor0226,
jhoncool,
korvin89,
kseniya57,
mournfulCoroner,
ogonkov,
sofiushko,
v4dyar4 and
zamkovskaya
as code owners
Contributor
Reviewer's GuideUpgrade Storybook and related tooling to 9.1.20 and update MDX docs to use the new @storybook/addon-docs/blocks entrypoint and compatible syntax, plus minor formatting fixes. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since you're already updating to Storybook 9.1.x, consider switching MDX imports to the recommended
@storybook/blocksentrypoint instead of@storybook/addon-docs/blocksto avoid relying on internal paths and align with the current API surface.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since you're already updating to Storybook 9.1.x, consider switching MDX imports to the recommended `@storybook/blocks` entrypoint instead of `@storybook/addon-docs/blocks` to avoid relying on internal paths and align with the current API surface.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
|
Preview is ready. |
Contributor
|
🎭 Component Tests Report is ready. |
Contributor
Author
|
I going to close this pr. @aeksandla made the updates to storybook v10 within the #2638 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2421
the problem fixed in the storybookjs/storybook#31730
Summary by Sourcery
Upgrade Storybook tooling and align MDX docs with the new addon-docs blocks API.
Build:
Documentation: