fix(Settings): extend description SettingsItem prop (#136)

* fix(Settings): extend description SettingsItem prop * chore: tune SettingsDemo
gravity-ui · Oct 13, 2023 · c285014 · c285014
1 parent f8f8491
commit c285014
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 4 deletions.
diff --git a/src/components/Settings/README.md b/src/components/Settings/README.md
@@ -55,7 +55,7 @@ The components provides layouting functionality of settings panel with the follo
 | renderTitleComponent | Function        |          |          | Cusomt header of                                           |
 | align                | 'top', 'center' |          | 'center' | Item alignment                                             |
 | mode                 | 'row'           |          |          | Layout for mobile. Title and control will be placed in row |
-| description          | string          |          |          | Description of item                                        |
+| description          | ReactNode       |          |          | Description of item                                        |
 
 ### Usage
 

diff --git a/src/components/Settings/Settings.tsx b/src/components/Settings/Settings.tsx
@@ -63,7 +63,7 @@ export interface SettingsItemProps {
     children: React.ReactNode;
     withBadge?: boolean;
     mode?: 'row';
-    description?: string;
+    description?: React.ReactNode;
 }
 
 export interface SettingsContextType

diff --git a/src/components/Settings/__stories__/SettingsDemo.tsx b/src/components/Settings/__stories__/SettingsDemo.tsx
@@ -93,7 +93,14 @@ export const SettingsComponent = React.memo(
                             </Settings.Item>
                         </Settings.Section>
                         <Settings.Section title="Common" withBadge={withBadge}>
-                            <Settings.Item title="Default VCS">
+                            <Settings.Item
+                                title="Default VCS"
+                                description={
+                                    <div>
+                                        <i>Description</i>
+                                    </div>
+                                }
+                            >
                                 <RadioButton
                                     value={settings.vcs}
                                     onChange={(event) => {
@@ -131,7 +138,6 @@ export const SettingsComponent = React.memo(
                                 renderTitleComponent={(highlightedTitle) => (
                                     <div>
                                         <span>{highlightedTitle || 'Theme'}</span>
-                                        <HelpPopover content="Change the look and feel of your application" />
                                     </div>
                                 )}
                             >