Skip to content

Relax validation on text_format to allow for empty strings #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esmet merged 1 commit into from
Dec 10, 2020
Merged

Relax validation on text_format to allow for empty strings #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/envoy/config/core/v3/substitution_format_string.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ message SubstitutionFormatString {
//
// upstream connect error:204:path=/foo
//
string text_format = 1 [(validate.rules).string = {min_bytes: 1}];
string text_format = 1;

// Specify a format with command operators to form a JSON string.
// Its details is described in :ref:`format dictionary<config_access_log_format_dictionaries>`.
Expand Down
2 changes: 1 addition & 1 deletion api/envoy/config/core/v4alpha/substitution_format_string.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated_api_shadow/envoy/config/core/v3/substitution_format_string.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion generated_api_shadow/envoy/config/core/v4alpha/substitution_format_string.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.