This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Add an event for when a session recording is accessed#970
Merged
Conversation
ryanclark
force-pushed
the
ryan/add-session-recording-view-event
branch
from
fceb7ab to
40c15d7
Compare
zmb3
reviewed
Jul 13, 2022
ryanclark
changed the title
| color="light" | ||
| font-size="3" | ||
| /> | ||
| App Session Started |
There was a problem hiding this comment.
Confused as to why this would be removed given this change.
There was a problem hiding this comment.
It looks like APP_SESSION_START has the same event code:
Member
Author
There was a problem hiding this comment.
Yeah, turns out I missed the second block of session events (gravitational/teleport#14302 (review)) - I'll change the code
kimlisa
reviewed
Jul 13, 2022
Contributor
kimlisa
left a comment
kimlisa
left a comment
There was a problem hiding this comment.
i think it's worth to add instructions on how to add events on our root README, it's a very common addition (and various devs come in to add them) and the steps are all the same as well as the files touched, see example here: #561,
the instructions are also detailed in this file:
, but i guess it's hard to see
ibeckermayer
approved these changes
Jul 14, 2022
ryanclark
force-pushed
the
ryan/add-session-recording-view-event
branch
from
428db31 to
4b0b466
Compare
strideynet
approved these changes
Aug 10, 2022
Contributor
|
@ryanclark is there any work left here? We can merge this at any time (backend doesn't need to be ready) |
Member
Author
@zmb3 Yeah it's ready to go, I'll sort it out in a couple of hours once I'm at my MacBook |
ryanclark
force-pushed
the
ryan/add-session-recording-view-event
branch
from
4b0b466 to
2dae3ed
Compare
ryanclark
added a commit
to gravitational/teleport
that referenced
this pull request
Aug 22, 2022
This adds a new SessionRecordingAccess event that is emitted every time a session's events are queried, or if a session's events are streamed. This event is emitted by both v1 and v2 of the API, so both the web UI and tsh play will result in an event in the audit log. Implements #13880. The frontend change for supporting this event type is here - gravitational/webapps#970.
ryanclark
added a commit
to gravitational/teleport
that referenced
this pull request
Aug 22, 2022
This adds a new SessionRecordingAccess event that is emitted every time a session's events are queried, or if a session's events are streamed. This event is emitted by both v1 and v2 of the API, so both the web UI and tsh play will result in an event in the audit log. Implements #13880. The frontend change for supporting this event type is here - gravitational/webapps#970.
ryanclark
added a commit
to gravitational/teleport
that referenced
this pull request
Aug 22, 2022
This adds a new SessionRecordingAccess event that is emitted every time a session's events are queried, or if a session's events are streamed. This event is emitted by both v1 and v2 of the API, so both the web UI and tsh play will result in an event in the audit log. Implements #13880. The frontend change for supporting this event type is here - gravitational/webapps#970.
This was referenced Aug 23, 2022
ryanclark
added a commit
to gravitational/teleport
that referenced
this pull request
Aug 30, 2022
This adds a new SessionRecordingAccess event that is emitted every time a session's events are queried, or if a session's events are streamed. This event is emitted by both v1 and v2 of the API, so both the web UI and tsh play will result in an event in the audit log. Implements #13880. The frontend change for supporting this event type is here - gravitational/webapps#970.
ryanclark
added a commit
to gravitational/teleport
that referenced
this pull request
Aug 30, 2022
Record when a session recording is accessed This adds a new SessionRecordingAccess event that is emitted every time a session's events are queried, or if a session's events are streamed. This event is emitted by both v1 and v2 of the API, so both the web UI and tsh play will result in an event in the audit log. Implements #13880. The frontend change for supporting this event type is here - gravitational/webapps#970.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of gravitational/teleport#13880, a new event has been added (
SESSION_RECORDING_ACCESS, codeT2011I).This adds it to the frontend so it displays correctly -
