Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

SharedDirectoryAnnounce #960

Merged
ibeckermayer merged 12 commits into from
Jul 18, 2022
Merged

SharedDirectoryAnnounce #960

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2cbc1b0
super basic picker with logging
Jul 5, 2022
bc51777
Adds SharedDirectoryAnnounce
Jul 6, 2022
bc6586b
Removes recording icon
Jul 6, 2022
fa09ec3
reverting config to its rightful checkin state
Jul 6, 2022
becfad3
updates storybook and storybook test snapshot
Jul 7, 2022
17408f8
Adds types for File System Access API
Jul 7, 2022
edfe30d
prettier
Jul 7, 2022
66268a8
Merge branch 'master' into isaiah/directory-picker
Jul 7, 2022
cf9346a
Merge branch 'master' into isaiah/directory-picker
Jul 7, 2022
c141cf4
Moves onShareDirectory into a function rather than adding it inline t…
Jul 11, 2022
1f3cecb
Merge branch 'master' into isaiah/directory-picker
Jul 11, 2022
8b8fea5
Merge branch 'master' into isaiah/directory-picker
Jul 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions packages/teleport/src/DesktopSession/DesktopSession.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,11 @@ function Session(props: PropsWithChildren<State>) {
isSharingDirectory={isSharingDirectory}
onShareDirectory={() => {
setIsSharingDirectory(true);
const sharedDirHandle = window
.showDirectoryPicker()

@ravicious ravicious Jul 8, 2022

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to handle browsers which don't support this API?

@ibeckermayer ibeckermayer Jul 11, 2022

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I left that as a "known issue" for now: #959

.then(sharedDirHandle => {
console.log(sharedDirHandle);
});
}}
/>

Expand Down Expand Up @@ -218,3 +223,9 @@ const DesktopSessionAlert = styled(Alert)`
align-self: center;
min-width: 450px;
`;

declare global {
interface Window {
showDirectoryPicker: () => Promise<FileSystemDirectoryHandle>;
}
}