This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Add directory sharing to the ACL#951
Merged
ibeckermayer merged 1 commit intomasterfrom Jul 5, 2022
Merged
Conversation
ibeckermayer
force-pushed
the
isaiah/add-dir-sharing-to-acl
branch
from
9db9af9 to
6b5eb60
Compare
kimlisa
approved these changes
Jul 5, 2022
hatched
approved these changes
Jul 5, 2022
|
|
||
| const cfg = { | ||
| // TODO(isaiah): remove after feature is finished. | ||
| enableDirectorySharing: false, // note to reviewers: should be false in any PRs. |
ibeckermayer
pushed a commit
that referenced
this pull request
Jul 19, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Jul 19, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Jul 20, 2022
ibeckermayer
pushed a commit
that referenced
this pull request
Jul 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setting is also modulated by the
enableDirectorySharingconfig variable while the feature is still in development.Corresponds with gravitational/teleport#14103
v9 and v10 backport required