This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Conversation
ravicious
approved these changes
Jun 27, 2022
Member
ravicious
left a comment
ravicious
left a comment
There was a problem hiding this comment.
Nice, I'm glad we managed to fix this before the GA release!
Comment on lines
+66
to
+70
| When restoring the documents, we do not always have the leaf clusters already fetched. | ||
| In that case we can fall back to `clusterId` from a leaf cluster URI | ||
| (for a leaf cluster `clusterId` === `actualName`) | ||
| */ | ||
| const parsed = routing.parseClusterUri(clusterUri); |
| const parsed = routing.parseClusterUri(clusterUri); | ||
|
|
||
| if (!parsed?.params?.leafClusterId) { | ||
| throw new Error('Incorrect cluster URI'); |
Member
There was a problem hiding this comment.
This error message could provide more information though. :D Maybe something that at this point a leaf cluster URI was expected but the URI doesn't seem to include a leaf cluster ID?
gzdunek
added a commit
that referenced
this pull request
Jun 27, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/gravitational/webapps.e/issues/327