This repository was archived by the owner on Feb 8, 2024. It is now read-only.
useDocumentGateway: Pin shell to correct cluster#812
Merged
Conversation
Commit b5d30b1 fixed some reconnect issues, but it also introduced a locally scoped `cluster` variable. This made it seem like it's the cluster to which the given gateway belongs, but it was actually the root cluster. This commit renames the old `cluster` variable to `rootCluster`. It also makes sure that `workspaceDocumentsService.openNewTerminal` receives correct root & leaf cluster IDs.
Member
Author
|
Also, @gzdunek do you know when It seems to me that there should be no situation in which the root cluster is nil, since if you remove (log out of) a root cluster, we remove all its resources as well? |
Contributor
|
AFAIK there should be no situation when |
Member
Author
|
Ok, I'll remove those checks in a separate PR then so that we can safely backport this one to 1.0.1. |
gzdunek
approved these changes
May 5, 2022
ravicious
added a commit
that referenced
this pull request
May 5, 2022
Commit b5d30b1 fixed some reconnect issues, but it also introduced a locally scoped `cluster` variable. This made it seem like it's the cluster to which the given gateway belongs, but it was actually the root cluster. This commit renames the old `cluster` variable to `rootCluster`. It also makes sure that `workspaceDocumentsService.openNewTerminal` receives correct root & leaf cluster IDs.
This was referenced May 5, 2022
ravicious
added a commit
that referenced
this pull request
May 5, 2022
Commit b5d30b1 fixed some reconnect issues, but it also introduced a locally scoped `cluster` variable. This made it seem like it's the cluster to which the given gateway belongs, but it was actually the root cluster. This commit renames the old `cluster` variable to `rootCluster`. It also makes sure that `workspaceDocumentsService.openNewTerminal` receives correct root & leaf cluster IDs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes gravitational/webapps.e#269.
Commit b5d30b1 fixed some reconnect issues, but it also introduced a
locally scoped
clustervariable. This made it seem like it's the clusterto which the given gateway belongs, but it was actually the root cluster.
This commit renames the old
clustervariable torootCluster. It alsomakes sure that
workspaceDocumentsService.openNewTerminalreceivescorrect root & leaf cluster IDs.