This repository was archived by the owner on Feb 8, 2024. It is now read-only.
[v11] Connect: Accommodate for making gRPC server creds in shared process#1302
Merged
Conversation
…1220) * Add comment to resolveNetworkAddress * Log errors during boot of React app * Connect: Accommodate for making gRPC server creds in shared process * Adjust timeout for resolveNetworkAddress Some of the timeouts in preload.ts, the shared process and tshd are set to 10s. If the timeout to resolve the network address is lower or equal to that, those timeout won't have the chance kick in. Hence setting the timeout to a slightly larger value. * makeCert: Add subjectAltName to certs Without this, the cert generated by makeCert was failing when loaded in Go as the gRPC server cert. The error message was: x509: certificate relies on legacy Common Name field, use SANs instead See: * https://stackoverflow.com/a/31143907/742872 * Search for "subjectAltName" https://github.com/digitalbazaar/forge/blob/2bb97afb5058285ef09bcf1d04d6bd6b87cffd58/README.md * Fix lint issues * Reword comment Co-authored-by: Michael <michael.myers@goteleport.com> * Remove unused imports Co-authored-by: Michael <michael.myers@goteleport.com>
ravicious
changed the title
gzdunek
approved these changes
Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport #1220