This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Connect: Fix filtering internal logins#1292
Merged
Conversation
gzdunek
approved these changes
Oct 24, 2022
ravicious
added a commit
that referenced
this pull request
Oct 24, 2022
ravicious
added a commit
that referenced
this pull request
Oct 24, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in gravitational/teleport#17497 (comment) in the "Bundling multiple calls into one" section, we might as well rewrite the GetCluster endpoint so that it returns info about assumed requests and leaf clusters instead of making three separate calls.
In the meantime, this commit fixes removing internal logins when calling
syncClusterInfo.