This repository was archived by the owner on Feb 8, 2024. It is now read-only.
Add new audit event for app-access DynamoDB requests#1279
Merged
GavinFrazar merged 5 commits intomasterfrom Nov 17, 2022
Merged
Add new audit event for app-access DynamoDB requests#1279GavinFrazar merged 5 commits intomasterfrom
GavinFrazar merged 5 commits intomasterfrom
Conversation
Tener
approved these changes
Oct 25, 2022
kimlisa
approved these changes
Oct 25, 2022
GavinFrazar
force-pushed
the
gavinfrazar/improve_dynamodb_audit_events
branch
from
d900fd3 to
cb5cb2f
Compare
GavinFrazar
added a commit
that referenced
this pull request
Dec 24, 2022
* Add AppSessionDynamoDB audit event * Add fixtures new dynamo event to storybook and verify it rendered correctly * Update snapshot of storybook
GavinFrazar
added a commit
that referenced
this pull request
Dec 28, 2022
* Add new audit event for app-access DynamoDB requests (#1279) * Add AppSessionDynamoDB audit event * Add fixtures new dynamo event to storybook and verify it rendered correctly * Update snapshot of storybook * Update snapshot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issue: gravitational/teleport#15572
Related PR: gravitational/teleport#17595
I have followed the steps outlined in the README about adding a new audit event to the web ui.
I also verified the storybook renders as expected.
Note that the "body" field is the HTTP request body (which is already JSON), but I've setup the protos definition such that it marshals to JSON correctly without needing escape characters, so that's why it appears to be "in-line" - this is better UX than escaped JSON which requires a user to parse and unmarshal it themselves in order to pretty-print the event body with tools like
jqshould they play the app session chunk back withtsh play --format=json <chunk-id>.Screenshots of storybook: