Bump golang.org/x/net from 0.17.0 to 0.33.0#113
Conversation
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.17.0 to 0.33.0. - [Commits](golang/net@v0.17.0...v0.33.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
the
dependencies
| module github.com/gravitational/trace | ||
|
|
||
| go 1.15 | ||
| go 1.20 |
There was a problem hiding this comment.
Dependencies want various increased Go versions, as follows:
- testify wants 1.20 - https://github.com/stretchr/testify/blob/v1.8.3/go.mod
- /x/net wants 1.18 (updated by this PR) - https://cs.opensource.google/go/x/net/+/refs/tags/v0.33.0:go.mod
- grpc wants 1.17 - https://github.com/grpc/grpc-go/blob/v1.56.3/go.mod
These are all fairly old, past EOL Go versions. Since this is a library it makes sense to keep Go requirements as soft as can be, so I've updated trace to require 1.20. This and the security patch probably both warrant a new tag.
| ) | ||
|
|
||
| require ( | ||
| golang.org/x/sys v0.15.0 // indirect |
There was a problem hiding this comment.
Not sure why dependabot took out all indirects, but once I upped the Go version it all came back.
| @@ -1,1541 +1,30 @@ | |||
| cloud.google.com/go v0.26.0/go.mod h1:aQUYkXzVsufM+DwF1aE+0xfcU+56JwCaLick0ClmMTw= | |||
There was a problem hiding this comment.
go.sum changes seem like a huge win for us.
| uses: actions/checkout@v4 | ||
| - name: Setup Go | ||
| uses: actions/setup-go@v3 | ||
| uses: actions/setup-go@v5 |
There was a problem hiding this comment.
Updated to match the go-version-file example here: https://github.com/actions/setup-go?tab=readme-ov-file#getting-go-version-from-the-gomod-file.
Also updated other files so actions use consistent versions.
| golang.org/x/sys v0.28.0 // indirect | ||
| golang.org/x/text v0.21.0 // indirect | ||
| google.golang.org/genproto v0.0.0-20230410155749-daa745c078e1 // indirect | ||
| google.golang.org/protobuf v1.33.0 // indirect |
There was a problem hiding this comment.
protobuf needs to be at least v1.33.0 to dodge more CVEs.
|
Thanks, I'll merge this one and make a new tag. |
2 participants
Bumps golang.org/x/net from 0.17.0 to 0.33.0.
Commits
dfc720dgo.mod: update golang.org/x dependencies8e66b04html: use strings.EqualFold instead of lowering ourselvesb935f7bhtml: avoid endless loop on error token9af49efroute: remove unused sizeof* consts6705db9quic: clean up crypto streams when dropping packet protection keys4ef7588quic: handle ACK frame in packet which drops number space552d8acRevert "route: change from syscall to x/sys/unix"13a7c01Revert "route: remove unused sizeof* consts on freebsd"285e1cfgo.mod: update golang.org/x dependenciesd0a1049route: remove unused sizeof* consts on freebsdDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)You can disable automated security fix PRs for this repo from the Security Alerts page.