Skip to content

Update modules to reduce dependency tree. #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
creack wants to merge 1 commit into from
Closed

Update modules to reduce dependency tree. #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,13 @@ permissions: {}
jobs:
go-test:
name: Run Go tests
runs-on: ubuntu-22.04
runs-on: ubuntu-24.04
steps:
- name: Checkout
uses: actions/checkout@v2
uses: actions/checkout@v4
- name: Setup Go
uses: actions/setup-go@v3
uses: actions/setup-go@v5
with:
go-version: '1.17'
go-version: '1.23'
- name: Test
run: go test -race ./...
run: go test -v -race ./...
17 changes: 11 additions & 6 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,19 @@
module github.com/gravitational/trace

go 1.15
go 1.22
Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is quite a large leap for a library, is this enforced on us by gRPC? Should we consider moving trail to another module or removing it altogether and vendoring it in teleport?

Copy link
Copy Markdown
Author

@creack creack Dec 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is enforce by Go. 1.23 will not run the tests for anything lower, complaining about go mod needed tidy and reverting back to 1.22.

Copy link
Copy Markdown
Contributor

@rosstimothy rosstimothy Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm exploring removing trail, which pulls in grpc-go in #112. I cannot find any other consumers of the package outside of gravitational.


require (
github.com/stretchr/testify v1.8.3
golang.org/x/net v0.17.0
google.golang.org/grpc v1.56.3
github.com/stretchr/testify v1.10.0
golang.org/x/net v0.33.0
google.golang.org/grpc v1.69.2
)

require (
golang.org/x/sys v0.15.0 // indirect
golang.org/x/text v0.14.0 // indirect
github.com/davecgh/go-spew v1.1.1 // indirect
github.com/pmezard/go-difflib v1.0.0 // indirect
golang.org/x/sys v0.28.0 // indirect
golang.org/x/text v0.21.0 // indirect
google.golang.org/genproto/googleapis/rpc v0.0.0-20241015192408-796eee8c2d53 // indirect
google.golang.org/protobuf v1.35.1 // indirect
gopkg.in/yaml.v3 v3.0.1 // indirect
)
Loading