Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily remove flaky test. #992

Merged
merged 1 commit into from
May 16, 2017
Merged

Temporarily remove flaky test. #992

merged 1 commit into from
May 16, 2017

Conversation

russjones
Copy link
Contributor

Purpose

Removing TestExecCommandNoLocalPtyAndRemotePty because it was flakey and it's failure did not indicate any problems with Teleport. Created a Issue to track re-adding this test back in.

Implementation

n/a

Related Issue

#991

@klizhentas klizhentas self-requested a review May 16, 2017 20:59
// TestExecCommandNoLocalAndPtyRemotePty tests executing a command where you
// have no local PTY but have a remote PTY.
func (s *SrvSuite) TestExecCommandNoLocalPtyAndRemotePty(c *C) {
// 1 - command: seq 2 | ssh -tt localhost 'stty -opost; echo'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead of removing, you just c.Skip() and add warning, because we want this back

Copy link
Contributor

@klizhentas klizhentas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comments

@russjones russjones force-pushed the rjones/remove-test branch from 3cb2f9a to a0b857a Compare May 16, 2017 21:19
@russjones russjones force-pushed the rjones/remove-test branch from a0b857a to 100c286 Compare May 16, 2017 21:23
@russjones
Copy link
Contributor Author

@klizhentas Made the change you suggested.

@russjones russjones merged commit 323a51e into master May 16, 2017
@russjones russjones deleted the rjones/remove-test branch May 16, 2017 21:47
hatched pushed a commit to hatched/teleport-merge that referenced this pull request Nov 30, 2022
* Update user service
  - Adds FetchUser
  - Adds traits to type and response
* Remove all eslint disable import/named
hatched pushed a commit that referenced this pull request Dec 20, 2022
* Update user service
  - Adds FetchUser
  - Adds traits to type and response
* Remove all eslint disable import/named
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants