Alexey/new terminal #962
Merged
Alexey/new terminal #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # web/package.json # web/src/app/lib/term/terminal.js
klizhentas
approved these changes
May 1, 2017
|
I've tested it in various scenarios (trusted clusters of different versions) and there are no issues. It's 100% backwards-compatible. |
hatched
pushed a commit
that referenced
this pull request
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Go changes:
Js changes:
replacement of the old termjs with the new xtermjs
replacement of the 'underscore' library with 'lodash'
removal of the screen size handling from each tty websocket response.
adding buffering for websocket connection to handle much greater traffic
conversion of some react component to ES6 Classes.
clean-ups here and there
closes #933