Skip userinfo if provider doesn't support it. #915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While integrating the CoreOS Dex oidc (https://github.com/coreos/dex) with teleport we found a problem during the claim validation process:
Dex doesn't implement the UserInfo endpoint, which seems to be optional anyway according to the standard (see dexidp/dex#376).
Teleport auth service crashes when requesting this endpoint as in:
pc.UserInfoEndpoint
is casted to String.This PR tries to avoid this crash by checking for the UserInfoEndpoint presence in the provider configuration, using just the token claims in this case.
Do you think this would be a good approach?