Fix interactive sessions always exiting with code 0 #8081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
requested review from
klizhentas,
r0mant and
russjones
as code owners
rosstimothy
force-pushed
the
tross/fix-ssh-exit-code
branch
2 times, most recently
from
a5c7cb3 to
58f0f09
Compare
|
The issue linked to in the PR description seems to be incorrect BTW. |
rosstimothy
force-pushed
the
tross/fix-ssh-exit-code
branch
2 times, most recently
from
26b7826 to
a1c5b99
Compare
rosstimothy
force-pushed
the
tross/fix-ssh-exit-code
branch
from
a1c5b99 to
1fb30b4
Compare
Comment on lines
+1939
to
+1960
| case *ssh.ExitMissingError: | ||
| tc.ExitStatus = 1 |
There was a problem hiding this comment.
Not sure if this is semantically correct. Must ExitMissingError imply a failed/non-zero ExitStatus?
There was a problem hiding this comment.
I copied the behavior of non interactive sessions: https://github.com/gravitational/teleport/blob/master/lib/client/api.go#L1918
rosstimothy
force-pushed
the
tross/fix-ssh-exit-code
branch
from
5290e5a to
7f2d900
Compare
andrejtokarcik
approved these changes
Sep 2, 2021
rosstimothy
force-pushed
the
tross/fix-ssh-exit-code
branch
6 times, most recently
from
2e1f82e to
d4bbb01
Compare
rosstimothy
force-pushed
the
tross/fix-ssh-exit-code
branch
from
d4bbb01 to
00e9299
Compare
fspmarshall
approved these changes
Sep 13, 2021
klizhentas
approved these changes
Sep 13, 2021
zmb3
pushed a commit
that referenced
this pull request
Sep 23, 2021
* propogate error codes from interactive ssh sessions correctly (#3202)
kimlisa
added a commit
that referenced
this pull request
Nov 2, 2021
Removes the call for wait for ssh.Session end to check for errors in web terminal which fixes a regression bug where typing "exit" in web terminal does not return session end event. PR #8081 removed the need to check for errors as it correctly returns exit errors whereas before it returned nil.
kimlisa
added a commit
that referenced
this pull request
Nov 2, 2021
Removes the call for wait for ssh.Session end to check for errors in web terminal which fixes a regression bug where typing "exit" in web terminal does not return session end event. PR #8081 removed the need to check for errors as it correctly returns exit errors whereas before it returned nil.
kimlisa
added a commit
that referenced
this pull request
Nov 2, 2021
Removes the call for wait for ssh.Session end to check for errors in web terminal which fixes a regression bug where typing "exit" in web terminal does not return session end event. PR #8081 removed the need to check for errors as it correctly returns exit errors whereas before it returned nil.
kimlisa
added a commit
that referenced
this pull request
Nov 2, 2021
…8818) Removes the call for wait for ssh.Session end to check for errors in web terminal which fixes a regression bug where typing "exit" in web terminal does not return session end event. PR #8081 removed the need to check for errors as it correctly returns exit errors whereas before it returned nil.
kimlisa
added a commit
that referenced
this pull request
Nov 2, 2021
…8816) Removes the call for wait for ssh.Session end to check for errors in web terminal which fixes a regression bug where typing "exit" in web terminal does not return session end event. PR #8081 removed the need to check for errors as it correctly returns exit errors whereas before it returned nil.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Correctly propagate error codes from an interactive
tsh sshsession - fixes #3202Implementation
Waiton thessh.Sessionfor interactive sessionsTeleportClient.ExitStatusif there was anssh.ExitErrororssh.ExitMissingErrorreturned byrunShell