-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow roles to be unmarshalled from bootstrap config #7036
Conversation
e11b999
to
a0a4b53
Compare
a0a4b53
to
9c320a1
Compare
@fspmarshall Is there a reason we did not add support for roles to the bootstrap flag? |
@russjones Roles in We can and should add support for roles in to OSS now that #5419 has landed. This PR will need to updated to ensure that |
@fspmarshall happy to make the changes, any pointers as to where the feature flag changes will live? And what was |
@stefansedich Oops, just realized that you were an outside contributor. Thanks for the PR!
|
Ok gotcha thanks @fspmarshall ! in that case let me know if I can assist any further to land this one. |
@fspmarshall is this something that might be able to land in 7.0? I am currently running our own custom build of teleport so we can advance our POC but would be great to not have to keep running that for too long. |
@stefansedich 7.0 should be no problem. Closing this PR in favor of #7130 |
It as not possible to use
--bootstrap
with a bootstrap file that contained roles as I was receiving the following error:This PR adds support for unmarshalling roles from a bootstrap config file which appears to work but I might not understand some edge cases as to why this was not implemented so happy to be schooled 😅
I have done an end-to-end test loading our bootstrap.yaml which contains roles and it appears to function as expected. I also added an initial test around the bootstrap as I could not find any existing tests to add to, happy to tweak this if desired.