Skip to content

use the same static secret with the teleport-kube-agent chart#6619

Closed
timothy-spencer wants to merge 7 commits intogravitational:masterfrom
timothy-spencer:chartsharesecret
Closed

use the same static secret with the teleport-kube-agent chart#6619
timothy-spencer wants to merge 7 commits intogravitational:masterfrom
timothy-spencer:chartsharesecret

Conversation

@timothy-spencer
Copy link
Copy Markdown
Contributor

This should allow the teleport-kube-agent helm chart to actually be able to join the teleport-cluster.

@russjones
Copy link
Copy Markdown
Contributor

@timothy-spencer Thank you for your contribution!

@webvictim You're reworking Helm charts in #6344, can you take a look at this and see if these changes make sense in the context of new Helm charts?

@russjones russjones requested a review from webvictim April 28, 2021 21:17
@webvictim
Copy link
Copy Markdown
Contributor

@klizhentas @awly What do you think about this? IMO we shouldn't encourage setting static join tokens in the chart, but there isn't really a good alternative for using teleport-kube-agent until we fix #4832.

@awly
Copy link
Copy Markdown
Contributor

awly commented Apr 29, 2021

The list of static tokens should be opt-in, not added by default.
Otherwise, it's reasonable that teleport-cluster and teleport-kube-agent should be easy to set up with each other. I don't know what kind of refactoring @webvictim is doing and whether we'll keep both charts though.

@webvictim
Copy link
Copy Markdown
Contributor

We're keeping both charts and I agree that until teleport-kube-agent can support dynamic tokens, we should make it easier to use both together. I'll wait to see what @klizhentas thinks though.

@russjones russjones added the ux label May 5, 2021
@timothy-spencer
Copy link
Copy Markdown
Contributor Author

Any news on this? I'd love to be using your helm chart and not my fork. :-)

@webvictim
Copy link
Copy Markdown
Contributor

@timothy-spencer We won't implement this exactly as-is, but after #6344 is merged we'll take a look at a way to define a token which can be shared and used between the two charts. We're in the process of refactoring our Helm guides (teleport-cluster is written but teleport-kube-agent is still to be done) so it'll likely come along with that.

@timothy-spencer
Copy link
Copy Markdown
Contributor Author

I definitely saw a lot of activity over there in #6344, but until that lands, seems like this would be a quick fix for people who actually want to use teleport-kube-agent. I will definitely be excited to use dynamic join tokens down the road, though!!

@webvictim
Copy link
Copy Markdown
Contributor

#7123 has been merged which adds support for running teleport-kube-agent as a StatefulSet and using persistent storage. This makes the use of dynamic join tokens possible, so I'm going to close this PR. Thanks!

@webvictim webvictim closed this Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants